Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GraphBolt][CUDA] Handle edge case of %100 cache hit rate. #7080

Merged
merged 3 commits into from
Feb 3, 2024

Conversation

mfbalin
Copy link
Collaborator

@mfbalin mfbalin commented Feb 3, 2024

Description

When cache hit rate is %100, this function is called with 0-sized tensors. If it is called with empty tensors, then we do nothing and return as there is nothing to do.

Checklist

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [$CATEGORY] (such as [NN], [Model], [Doc], [Feature]])
  • I've leverage the tools to beautify the python and c++ code.
  • The PR is complete and small, read the Google eng practice (CL equals to PR) to understand more about small PR. In DGL, we consider PRs with less than 200 lines of core code change are small (example, test and documentation could be exempted).
  • All changes have test coverage
  • Code is well-documented
  • To the best of my knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change
  • Related issue is referred in this PR
  • If the PR is for a new model/paper, I've updated the example index here.

Changes

@dgl-bot
Copy link
Collaborator

dgl-bot commented Feb 3, 2024

To trigger regression tests:

  • @dgl-bot run [instance-type] [which tests] [compare-with-branch];
    For example: @dgl-bot run g4dn.4xlarge all dmlc/master or @dgl-bot run c5.9xlarge kernel,api dmlc/master

@dgl-bot
Copy link
Collaborator

dgl-bot commented Feb 3, 2024

Commit ID: cdd60eb

Build ID: 1

Status: ⚪️ CI test cancelled due to overrun.

Report path: link

Full logs path: link

@TristonC
Copy link
Collaborator

TristonC commented Feb 3, 2024

Confirmed the fix

@dgl-bot
Copy link
Collaborator

dgl-bot commented Feb 3, 2024

Commit ID: 441d74f

Build ID: 2

Status: ✅ CI test succeeded.

Report path: link

Full logs path: link

@TristonC TristonC merged commit 15695ed into dmlc:master Feb 3, 2024
2 checks passed
@mfbalin mfbalin deleted the gb_cuda_gpu_cache_zero_size_fix branch February 3, 2024 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants