Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GraphBolt] Refactor NeighborSampler and expose fine-grained datapipes. #6983

Merged
merged 40 commits into from
Feb 1, 2024
Merged

[GraphBolt] Refactor NeighborSampler and expose fine-grained datapipes. #6983

merged 40 commits into from
Feb 1, 2024

Commits on Jan 19, 2024

  1. prototyping

    @mfbalin
    mfbalin committed Jan 19, 2024
    Configuration menu
    Copy the full SHA
    b4c045f View commit details
    Browse the repository at this point in the history

Commits on Jan 20, 2024

  1. fix bug

    @mfbalin
    mfbalin committed Jan 20, 2024
    Configuration menu
    Copy the full SHA
    a26e354 View commit details
    Browse the repository at this point in the history

  2. remove print expressions, works now

    @mfbalin
    mfbalin committed Jan 20, 2024
    Configuration menu
    Copy the full SHA
    58a1190 View commit details
    Browse the repository at this point in the history

Commits on Jan 23, 2024

  1. Merge branch 'master' into gb_refactor_neighbor_sampler

    @mfbalin
    mfbalin authored Jan 23, 2024
    Configuration menu
    Copy the full SHA
    eedb8d1 View commit details
    Browse the repository at this point in the history

Commits on Jan 24, 2024

  1. add tests

    @mfbalin
    mfbalin committed Jan 24, 2024
    Configuration menu
    Copy the full SHA
    3d2ed98 View commit details
    Browse the repository at this point in the history

  2. use seeds_timestamp in preprocess

    @mfbalin
    mfbalin committed Jan 24, 2024
    Configuration menu
    Copy the full SHA
    105924a View commit details
    Browse the repository at this point in the history

  3. add docstring for linting

    @mfbalin
    mfbalin committed Jan 24, 2024
    Configuration menu
    Copy the full SHA
    bfb28ec View commit details
    Browse the repository at this point in the history

  4. fix linting

    @mfbalin
    mfbalin committed Jan 24, 2024
    Configuration menu
    Copy the full SHA
    e4becc9 View commit details
    Browse the repository at this point in the history

  5. fix argument bug

    @mfbalin
    mfbalin committed Jan 24, 2024
    Configuration menu
    Copy the full SHA
    428ff24 View commit details
    Browse the repository at this point in the history

  6. Merge branch 'master' into gb_refactor_neighbor_sampler

    @mfbalin
    mfbalin authored Jan 24, 2024
    Configuration menu
    Copy the full SHA
    85b0601 View commit details
    Browse the repository at this point in the history

  7. fix the bug

    @mfbalin
    mfbalin committed Jan 24, 2024
    Configuration menu
    Copy the full SHA
    866316e View commit details
    Browse the repository at this point in the history

  8. Merge branch 'master' into gb_refactor_neighbor_sampler

    @mfbalin
    mfbalin authored Jan 24, 2024
    Configuration menu
    Copy the full SHA
    e2793fd View commit details
    Browse the repository at this point in the history

Commits on Jan 27, 2024

  1. Merge branch 'master' into gb_refactor_neighbor_sampler

    @mfbalin
    mfbalin authored Jan 27, 2024
    Configuration menu
    Copy the full SHA
    2473722 View commit details
    Browse the repository at this point in the history

Commits on Jan 29, 2024

  1. address reviews

    @mfbalin
    mfbalin committed Jan 29, 2024
    Configuration menu
    Copy the full SHA
    2d1dda9 View commit details
    Browse the repository at this point in the history

  2. add docstring to the new MinibatchTransformer.

    @mfbalin
    mfbalin committed Jan 29, 2024
    Configuration menu
    Copy the full SHA
    fad7c50 View commit details
    Browse the repository at this point in the history

  3. address review properly.

    @mfbalin
    mfbalin committed Jan 29, 2024
    Configuration menu
    Copy the full SHA
    a8fdfc6 View commit details
    Browse the repository at this point in the history

  4. remove unused Mapper import for linting.

    @mfbalin
    mfbalin committed Jan 29, 2024
    Configuration menu
    Copy the full SHA
    933246f View commit details
    Browse the repository at this point in the history

Commits on Jan 30, 2024

  1. NeighborSampler2 now derives from MinibatchTransformer.

    @mfbalin
    mfbalin committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    cd68728 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into gb_refactor_neighbor_sampler

    @mfbalin
    mfbalin authored Jan 30, 2024
    Configuration menu
    Copy the full SHA
    c3a903d View commit details
    Browse the repository at this point in the history

  3. FInal refactoring of NeighborSampler.

    @mfbalin
    mfbalin committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    dcbfb4e View commit details
    Browse the repository at this point in the history

  4. Fix not only preprocess but also postprocess issue.

    @mfbalin
    mfbalin committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    21fe633 View commit details
    Browse the repository at this point in the history

  5. take back test changes.

    @mfbalin
    mfbalin committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    29861f1 View commit details
    Browse the repository at this point in the history

  6. fix in_subgraph_sampler

    @mfbalin
    mfbalin committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    232f2f3 View commit details
    Browse the repository at this point in the history

  7. Merge branch 'master' into gb_refactor_neighbor_sampler

    @mfbalin
    mfbalin authored Jan 30, 2024
    Configuration menu
    Copy the full SHA
    03bea25 View commit details
    Browse the repository at this point in the history

  8. add docstring for append_sampling_step.

    @mfbalin
    mfbalin committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    86d9c43 View commit details
    Browse the repository at this point in the history

Commits on Jan 31, 2024

  1. Address reviews, minimize changes, keep API exactly the same.

    @mfbalin
    mfbalin committed Jan 31, 2024
    Configuration menu
    Copy the full SHA
    f995d20 View commit details
    Browse the repository at this point in the history

  2. remove leftover changes.

    @mfbalin
    mfbalin committed Jan 31, 2024
    Configuration menu
    Copy the full SHA
    a64d34e View commit details
    Browse the repository at this point in the history

  3. minor change.

    @mfbalin
    mfbalin committed Jan 31, 2024
    Configuration menu
    Copy the full SHA
    e46b8c7 View commit details
    Browse the repository at this point in the history

  4. Make the function into a proper one so that it can be pickled.

    @mfbalin
    mfbalin committed Jan 31, 2024
    Configuration menu
    Copy the full SHA
    8cc858c View commit details
    Browse the repository at this point in the history

  5. make the lambda into a proper function so that it can be pickled.

    @mfbalin
    mfbalin committed Jan 31, 2024
    Configuration menu
    Copy the full SHA
    02ca357 View commit details
    Browse the repository at this point in the history

  6. linting.

    @mfbalin
    mfbalin committed Jan 31, 2024
    Configuration menu
    Copy the full SHA
    19b4367 View commit details
    Browse the repository at this point in the history

  7. Merge branch 'master' into gb_refactor_neighbor_sampler

    @mfbalin
    mfbalin authored Jan 31, 2024
    Configuration menu
    Copy the full SHA
    67d6f71 View commit details
    Browse the repository at this point in the history

  8. final linting.

    @mfbalin
    mfbalin committed Jan 31, 2024
    Configuration menu
    Copy the full SHA
    144134c View commit details
    Browse the repository at this point in the history

  9. Merge branch 'master' into gb_refactor_neighbor_sampler

    @mfbalin
    mfbalin authored Jan 31, 2024
    Configuration menu
    Copy the full SHA
    96bac52 View commit details
    Browse the repository at this point in the history

  10. Cleanup NeighborSampler as it does not need to store anything itself.

    @mfbalin
    mfbalin committed Jan 31, 2024
    Configuration menu
    Copy the full SHA
    718cab8 View commit details
    Browse the repository at this point in the history

  11. linting

    @mfbalin
    mfbalin committed Jan 31, 2024
    Configuration menu
    Copy the full SHA
    ee3a7d7 View commit details
    Browse the repository at this point in the history

Commits on Feb 1, 2024

  1. address reviews by not passing sampler as string argument.

    @mfbalin
    mfbalin committed Feb 1, 2024
    Configuration menu
    Copy the full SHA
    1d906e7 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into gb_refactor_neighbor_sampler

    @mfbalin
    mfbalin authored Feb 1, 2024
    Configuration menu
    Copy the full SHA
    6ab2e75 View commit details
    Browse the repository at this point in the history

  3. Talk about sampling_stages in the SubgraphSampler API.

    @mfbalin
    mfbalin committed Feb 1, 2024
    Configuration menu
    Copy the full SHA
    6f880c0 View commit details
    Browse the repository at this point in the history

  4. add more documentation for sampling_stages.

    @mfbalin
    mfbalin committed Feb 1, 2024
    Configuration menu
    Copy the full SHA
    5d907ee View commit details
    Browse the repository at this point in the history