Fixed small bug that broke the "Launch Now" button at the end of app …

…creation. Updated docs. Made notarize-check a prerequisite of notarize-staple target in Makefile.
dmarmor · Jun 23, 2020 · 07fb1ca · 07fb1ca
1 parent 9e8f638
commit 07fb1ca
Show file tree

Hide file tree

Showing 5 changed files with 7 additions and 2 deletions.
diff --git a/README.md b/README.md
@@ -39,6 +39,8 @@ Epichrome is open source and a labor of love, made possible by the generosity of
 
 - The built-in engine has been updated to Brave 1.10.97.
 
+- The "Launch Now" button at the end of app creation works again after being broken in 2.3.3.
+
 *Check out the [**change log**](https://github.com/dmarmor/epichrome/blob/master/app/CHANGELOG.md "CHANGELOG.md") for the full list.*
 
 

diff --git a/app/CHANGELOG.md b/app/CHANGELOG.md
@@ -5,6 +5,8 @@ This project adheres to [Semantic Versioning](http://semver.org/).
 ## [2.3.4] - 2020-06-23
 ### Changed
 - Updated built-in engine to Brave 1.10.97
+### Fixed
+- The "Launch Now" button at the end of app creation works again after being broken in 2.3.3
 
 ## [2.3.3] - 2020-06-18
 ### Changed

diff --git a/app/Makefile b/app/Makefile
@@ -328,7 +328,7 @@ notarize-check:
 		echo 'Created check file & issues manifest.' ; \
 	else echo 'No request file found.' ; fi
 
-notarize-staple:
+notarize-staple: notarize-check
 	@if [[ ! -f 'epichrome-$(VERSION).pkg' ]] ; then \
 		echo '*** Unable to find epichrome-$(VERSION).pkg' ; false ; \
 	fi

diff --git a/app/src/main.js b/app/src/main.js
@@ -1146,7 +1146,7 @@ function doStep(aStepNum) {
         if (myDlgResult == "Launch Now") {
             delay(1);
             try {
-                shell("/usr/bin/open ", gAppPath);
+                shell("/usr/bin/open", gAppPath);
             } catch(myErr) {
                 // do I want some error reporting? /usr/bin/open is unreliable with errors
             }

diff --git a/app/src/welcome/welcome.html b/app/src/welcome/welcome.html
@@ -100,6 +100,7 @@ <h3 class="group_pg pg_update pg_change_engine pg_reset">Changes to This App</h3
                 <h3>New in Version <span id="update_version_minor">EPIVERSION</span></h3>
                 <ul>
                   <li>Built-in engine updated to Brave 1.10.97</li>
+                  <li>The "Launch Now" button at the end of app creation works again after being broken in 2.3.3</li>
                 </ul>
               </div>
               <!-- hide this for x.x.0 releases -->
Original file line number	Diff line number	Diff line change
Expand Up		@@ -39,6 +39,8 @@ Epichrome is open source and a labor of love, made possible by the generosity of

		- The built-in engine has been updated to Brave 1.10.97.

		- The "Launch Now" button at the end of app creation works again after being broken in 2.3.3.

		Check out the [change log](https://github.com/dmarmor/epichrome/blob/master/app/CHANGELOG.md "CHANGELOG.md") for the full list.


Expand Down