Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Signing event: sign/migration #98

Open
wants to merge 12 commits into
base: main
Choose a base branch
from
Open

Signing event: sign/migration #98

wants to merge 12 commits into from

Conversation

github-actions[bot]
Copy link

Processing signing event sign/migration, please wait.

Copy link
Author

Current signing event state

Event sign/migration (commit 7038bd2)

✅ root

Role root is verified and signed by 0/3 (3/3) signers (@dlorenc, @joshuagl, @bobcallaway).
Still missing signatures from @mnm678, @SantiagoTorres
Signers can sign these changes by running tuf-on-ci-sign sign/migration

✅ targets

Role targets is verified and signed by 3/3 signers (@dlorenc, @joshuagl, @bobcallaway).
Still missing signatures from @mnm678, @SantiagoTorres
Signers can sign these changes by running tuf-on-ci-sign sign/migration

✅ registry.npmjs.org

Role registry.npmjs.org is verified and signed by 1/1 signers (azurekms://npm-tuf-delegate.vault.azure.net/keys/npm-tuf-delegate-2024-08/e2772c1d01ca400da571096889f1660e).

Signing event is successful

Threshold of signatures has been reached: this signing event can be reviewed and merged.

@github-actions github-actions bot marked this pull request as ready for review August 27, 2024 13:13
@bobcallaway
Copy link

Current signing event state

Event sign/migration (commit 7038bd2)

✅ root

Role root is verified and signed by 0/3 (3/3) signers (@dlorenc, @joshuagl, @bobcallaway). Still missing signatures from @mnm678, @SantiagoTorres Signers can sign these changes by running tuf-on-ci-sign sign/migration

✅ targets

Role targets is verified and signed by 3/3 signers (@dlorenc, @joshuagl, @bobcallaway). Still missing signatures from @mnm678, @SantiagoTorres Signers can sign these changes by running tuf-on-ci-sign sign/migration

✅ registry.npmjs.org

Role registry.npmjs.org is verified and signed by 1/1 signers (azurekms://npm-tuf-delegate.vault.azure.net/keys/npm-tuf-delegate-2024-08/e2772c1d01ca400da571096889f1660e).

Signing event is successful

Threshold of signatures has been reached: this signing event can be reviewed and merged.

@jku @kommendorkapten note the count on root says 0/3 (3/3)

@jku
Copy link

jku commented Aug 27, 2024

This workflow that created the PR ran in dans fork: looks like we need to add some checks to the signing event workflow, it really shouldn't run in forks even if GH actions is enabled

@bobcallaway I just left a comment in the actual PR: it's a cosmetic migration issue that should not happen after this initial event

@dlorenc you can just close this one

@jku
Copy link

jku commented Aug 27, 2024

tuf-on-ci issue for this theupdateframework/tuf-on-ci#418

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants