forked from unbroken-dome/gradle-xjc-plugin
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump org.jetbrains.dokka from 0.10.1 to 1.8.20 #19
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See link from Feb 2021: https://blog.gradle.org/jcenter-shutdown
PR#28 Issue#27 overlaps this commit. Remove: com.sun.xml.bind:jaxb-xjc:3.0.0-M4 com.sun.xml.bind:jaxb-impl:3.0.0-M4 Replace with: com.sun.xml.bind:jaxb-xjc:3.0.2 com.sun.xml.bind:jaxb-core:3.0.2 com.sun.xml.bind:jaxb-impl:3.0.2 jakarta.xml.bind:jakarta.xml.bind-api:3.0.1
Issue#31 overlaps this commit.
com.sun.xml.bind:jaxb-xjc:2.4.0-b180830.0438 com.sun.xml.bind:jaxb-core:2.3.0.1 // there is no 2.4 version com.sun.xml.bind:jaxb-impl:2.4.0-b180830.0438 javax.xml.bind:jaxb-api:2.4.0-b180830.0359
Remove: com.sun.xml.bind:jaxb-xjc:2.3.3 Replace with: com.sun.xml.bind:jaxb-xjc:2.3.8 com.sun.xml.bind:jaxb-core:2.3.0.1 com.sun.xml.bind:jaxb-impl:2.3.8 javax.xml.bind:jaxb-api:2.3.1
Removed: javax.xml.bind:jaxb-api:2.2.11 Replaced with: javax.xml.bind:jaxb-api:2.2.12
Using: com.sun.xml.bind:jaxb-xjc:4.0.2 com.sun.xml.bind:jaxb-core:4.0.2 com.sun.xml.bind:jaxb-impl:4.0.2 jakarta.xml.bind:jakarta.xml.bind-api:4.0.0
Due to 4.0 support being added there is no easily available version of the XJC tool we can switch to that the plugin does not support. This is good news for the plugin project, but not this test. So it has been disabled. It should be possiblle to validate to test works if you wind back SCM history to somewhere between the time the IT was added and a commit or 2 before it was disabled.
This seems more correct when investigating Issue#34 concerning docLocale usage.
It is not entirely clear to me why using Locale type directly is better than just keeping the setting as a string and converting it just before use. The Gradle documentation does indicate that anything Serializable can be used as a Property, Locale is Serialiable so I'm not sure why it doesn't work as-is. It would be ideal if it was to be kept as Locale type and if both a Locale or a String can be assigned to the property and it just works. But I could not find out how to provide an accepted type convertor that works in both Groovy and Kotlin DSLs. The other alternative is to proivide a function like: docLocale = locale('it') docLocale = locale(Locale.ITALIAN) It it not clear if the feature previously worked when set inside the DSL, I was unable to create a TestCase that demonstrated it did. It only seemed to work as a gradle.properties setting. This commit does not change the previous behaviour with regards to gradle.properties use, but it does allow it to be set from inside the DSL now in a consistent way to the gradle.properties string property.
This removes the hardwired block that prevents the plugin from being used against any future version of XJC where the MANIFEST.MF Specification-Version does not match a known version. This will warn in this situation at this time. This commit is higher up the patch-set so it can be better tested before support for 4.0 is added. I would be my intention to progress this commit into requiring at least a configuration boolean to be set to authorise this best-effort so that consumers automated build system start to fail and an administrative decision is made to proceed. The decision would be based on an informed error message about what to do and where to look in documentation for support.
The plugin will fail gradle builds (by default) when it encounters an XJC tool version that does not have a supported version in its MANIFEST.MF Specification-Version attribute. This setting allows the project administrator to override the failure to request the plugin try on a best-effort basis to reuse a strategy of a supported version and continue. Configuring would use the strategy of the latest known supported XJC tool version: xjc.xjcVersionUnsupportedStrategy='auto-resolve' This reduces the onus on the plugin author and maintenance around the releases of a new XJC tool.
Dependabot couldn't find the original pull request head commit, 136a771.
Bumps [org.spekframework.spek2:spek-runner-junit5](https://github.com/spekframework/spek) from 2.0.9 to 2.0.15. - [Release notes](https://github.com/spekframework/spek/releases) - [Changelog](https://github.com/spekframework/spek/blob/2.x/docs/breaking-changes.md) - [Commits](spekframework/spek@2.0.9...2.0.15) --- updated-dependencies: - dependency-name: org.spekframework.spek2:spek-runner-junit5 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>
Dependabot couldn't find the original pull request head commit, 4756bc1.
Dependabot couldn't find the original pull request head commit, 4d11123.
Bumps [actions/deploy-pages](https://github.com/actions/deploy-pages) from 1 to 2. - [Release notes](https://github.com/actions/deploy-pages/releases) - [Commits](actions/deploy-pages@v1...v2) --- updated-dependencies: - dependency-name: actions/deploy-pages dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps org.unbroken-dome.test-sets from 3.0.1 to 4.0.0. --- updated-dependencies: - dependency-name: org.unbroken-dome.test-sets dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps org.ow2.asm:asm from 9.4 to 9.5. --- updated-dependencies: - dependency-name: org.ow2.asm:asm dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps org.jetbrains.dokka from 0.10.1 to 1.8.20. --- updated-dependencies: - dependency-name: org.jetbrains.dokka dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>
dependabot
bot
added
dependencies
Pull requests that update a dependency file
java
Pull requests that update Java code
labels
Jun 6, 2023
Superseded by #21. |
dependabot
bot
deleted the
dependabot/gradle/org.jetbrains.dokka-1.8.20
branch
December 10, 2023 00:43
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps org.jetbrains.dokka from 0.10.1 to 1.8.20.
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)