code review fixes

src/protagonist/Engine.Tests/Ingest/Image/Appetiser/AppetiserClientTests.cs

@@ -82,7 +82,6 @@ public async Task ProcessImage_CreatesAndRemovesRequiredDirectories()
     [Fact]
     public async Task ProcessImage_False_IfImageProcessorCallFails()
     {
-        // Arrange
         // Arrange
         var imageProcessorResponse = new AppetiserResponseErrorModel()
         {

src/protagonist/Engine/Ingest/Image/Appetiser/AppetiserClient.cs

@@ -98,7 +98,7 @@ public async Task<bool> ProcessImage(IngestionContext context)
         return (dest, thumb);
     }
 
-    private async Task<AppetiserResponse> CallImageProcessor(IngestionContext context,
+    private async Task<IAppetiserResponse> CallImageProcessor(IngestionContext context,
         ImageProcessorFlags processorFlags)
     {
         // call tizer/appetiser
@@ -113,9 +113,8 @@ private async Task<AppetiserResponse> CallImageProcessor(IngestionContext contex
         }
 
         using var response = await httpClient.SendAsync(request);
-
-        // TODO - it's possible to get a 200 when appetiser doesn't do anything, e.g. body not understood
-        AppetiserResponse? responseModel = null;
+
+        IAppetiserResponse? responseModel;
 
         if (response.IsSuccessStatusCode)
         {

src/protagonist/Engine/Ingest/Image/Appetiser/Models/AppetiserResponse.cs

@@ -1,6 +1,5 @@
 namespace Engine.Ingest.Image.Appetiser;
 
-public class AppetiserResponse
+public interface IAppetiserResponse
 {
-    public ResponseType ResponseType { get; init; }  
 }

src/protagonist/Engine/Ingest/Image/Appetiser/Models/AppetiserResponseErrorModel.cs

@@ -3,12 +3,8 @@
 /// <summary>
 /// Response model for receiving error requests back from Appetiser.
 /// </summary>
-public class AppetiserResponseErrorModel : AppetiserResponse
+public class AppetiserResponseErrorModel : IAppetiserResponse
 {
-    public AppetiserResponseErrorModel()
-    {
-        ResponseType = ResponseType.ErrorResponse;
-    }
     public string Message { get; set; }
     public string Status { get; set; }
 }

src/protagonist/Engine/Ingest/Image/Appetiser/Models/AppetiserResponseModel.cs

@@ -1,21 +1,10 @@
 namespace Engine.Ingest.Image.Appetiser;
 
-public enum ResponseType
-{
-    SuccessResponse,
-    ErrorResponse
-}
-
 /// <summary>
 /// Response model for receiving requests back from Appetiser.
 /// </summary>
-public class AppetiserResponseModel : AppetiserResponse
+public class AppetiserResponseModel : IAppetiserResponse
 {
-    public AppetiserResponseModel()
-    {
-        ResponseType = ResponseType.SuccessResponse;
-    }
-
     public string ImageId { get; set; }
     public string JobId { get; set; }
     public string Optimisation { get; set; }