-
-
Notifications
You must be signed in to change notification settings - Fork 700
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added a new popGrapheme function to std.uni #9053
Open
dukc
wants to merge
2
commits into
dlang:master
Choose a base branch
from
dukc:popGrapheme
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+134
−17
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,38 @@ | ||
Added popGrapheme function to std.uni. | ||
|
||
The new function is a cross between the existing $(REF graphemeStride, std, | ||
uni) and $(REF decodeGrapheme, std, uni) functions. The new function both | ||
supports `@safe pure nothrow @nogc` like `graphemeStride` does as long as you | ||
don't rely on autodecoding (side node: `@nogc` support for `graphemeStride` | ||
added in this release), and works with any non-array ranges just like | ||
`decodeGrapheme` does. | ||
|
||
Example: | ||
|
||
------- | ||
import std.uni; | ||
|
||
// Two Union Jacks of the Great Britain in each | ||
string s = "\U0001F1EC\U0001F1E7\U0001F1EC\U0001F1E7"; | ||
wstring ws = "\U0001F1EC\U0001F1E7\U0001F1EC\U0001F1E7"; | ||
dstring ds = "\U0001F1EC\U0001F1E7\U0001F1EC\U0001F1E7"; | ||
|
||
// String pop length in code units, not points. | ||
assert(s.popGrapheme() == 8); | ||
assert(ws.popGrapheme() == 4); | ||
assert(ds.popGrapheme() == 2); | ||
|
||
assert(s == "\U0001F1EC\U0001F1E7"); | ||
assert(ws == "\U0001F1EC\U0001F1E7"); | ||
assert(ds == "\U0001F1EC\U0001F1E7"); | ||
|
||
import std.algorithm.comparison : equal; | ||
import std.algorithm.iteration : filter; | ||
|
||
// Also works for non-random access ranges as long as the | ||
// character type is 32-bit. | ||
auto testPiece = "\r\nhello!"d.filter!(x => !x.isAlpha); | ||
// Windows-style line ending is two code point in a single grapheme. | ||
assert(testPiece.popGrapheme() == 2); | ||
assert(testPiece.equal("!"d)); | ||
------- |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This side note sounds like it should be its own PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is. I felt an added
@nogc
compability to an existing funtion alone wasn't worth a changelog entry so didn't add one in that PR. But since I'm writing here thatgraphemeStride
is@nogc
anyway, which until very recently wasn't the case, I feel it's useful to mention it. As in: "this note applies only with the latest compiler/Phobos".