-
-
Notifications
You must be signed in to change notification settings - Fork 701
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Issue 23977 - [REG2.102] cannot use getSymbolsByUDA on template struct with alias member #8775
base: stable
Are you sure you want to change the base?
Conversation
Thanks for your pull request and interest in making D better, @RazvanN7! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please see CONTRIBUTING.md for more information. If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment. Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.
|
// exclude basic types and derived types | ||
(isType!member && !isAggregateType!member && !is(member == enum)) || | ||
// exclude aliases to expressions such as string literals | ||
__traits(compiles, { auto ex = member; })) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is probably not the best idea to test if member is an expression. I took inspiration from the isExpressions
template. I did not want to use it to not cause avoidable template bloat.
I have a hard time understanding why this change causes a linker error:
So, there's some B symbol for which the init is not generated? Probably a compiler bug. |
Ping, this bug is still preventing Weka from using newer compilers. Thanks! |
…truct with alias member
@RazvanN7 is there anything we can do about this? Regressions are high priority and we'd like to get this fixed. |
Need to exclude expressions when looking to get attributes.