Upgrade versions used by the test-suite #478
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Versions prior to v2.087.1 do not work on Mac OSX 10.15, so upgrade the versions as they are inconsequential to the test.
|
Thanks for your pull request, @Geod24! Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. |
The versions used in the test were very old, and none of them would work on a recent OSX machine. Due to the age of such release, they could also confuse new contributors as many bugfixes / features were missing.
Geod24
commented
Dec 29, 2020
| @@ -3,30 +3,30 @@ | |||
| set -uexo pipefail | |||
|
|
|||
| compilers=( | |||
| dmd-2.064 | |||
There was a problem hiding this comment.
Hum, this was used to test that the old pattern (dmd-2.064 as opposed to dmd-2.064.0) works, I suppose ?
Could we do it in a way that doesn't run the compiler though ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was trying to upgrade this repository to use Github CI instead of Travis, and ran into some issues on OSX, so figured it'd be a good time to upgrade.