-
-
Notifications
You must be signed in to change notification settings - Fork 609
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix bugzilla issue 24871 - DDoc strips indent in triple slash comments #17082
Conversation
Thanks for your pull request and interest in making D better, @ArthaTi! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please see CONTRIBUTING.md for more information. If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment. Bugzilla references
Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub run digger -- build "master + dmd#17082" |
Removes code in the lexer responsible for removing leading spaces in triple slash doc comments. This affects the test file for issue 14413; two more spaces appear, but they are not significant in the HTML output.
There's a few CI failures. I do not understand the logs from Azure pipelines. The buildkite error is from exactly the same mismatch that happens in |
Three options are:
Fixing DDox is nontrivial because when you change the expected output, it will fail as long as it's using an older DMD, so you need to make the test pass with dmd before and after this PR. Removing the test in the buildkite script works as a quick hack, but it's not ideal. Maybe you can still strip 1 space after /// Lorem
/// Ipsum Rather than: ///Lorem
///Ipsum |
Removes code in the lexer responsible for removing leading spaces in triple slash doc comments.
This affects the test file for issue 14413; two more spaces appear, but they are not significant in the HTML output.