merge stable #16276
Merged
merge stable #16276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The issue is caused by compiling druntime/phobos and the application with different flags. The template instance for __switch_errorT is not included in the build of druntime/phobos, because they are compiled with -release. DMD will also not include it in an application compiled without -release, because it assumes, that it is already in druntime. See comment https://issues.dlang.org/show_bug.cgi?id=20802#c3 by Spoov. The template instance for __switch_errorT is now always instantiated in druntime, so it is part of the ABI of druntime.
Having this at the `Expression` level is useful to libdparse and will also help fix this regression https://issues.dlang.org/show_bug.cgi?id=24371 whose underlying issue is that the lowering doesn't take parentheses into account. This reverts the follwoing commits - 6e604e2 - e60d027 - 71ffbe0
…t operator precedence Rethink lowering logic to account for parentheses and operator associativity. Signed-off-by: Teodor Dutu <[email protected]>
…JC_PROTOCOL_$_Foo
…bol table and dynamic symbol table differ
…object.o, assuming: macOS Co-authored-by: Jacob Carlborg <[email protected]>
… to a movq instruction
… movq instruction
… section(2) with no content
…fer.size()), function addAtom
|
Thanks for your pull request, @ibuclaw! Bugzilla references
Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub run digger -- build "master + dmd#16276" |
thewilsonator
approved these changes
Mar 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expression.parens