Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fatal() in tocsym.d should be asserts #16274

Merged
merged 1 commit into from
Mar 1, 2024

Conversation

WalterBright
Copy link
Member

These states should never get this far, so they should be asserts.

@WalterBright WalterBright added Easy Review Refactoring No semantic changes to code labels Mar 1, 2024
@dlang-bot
Copy link
Contributor

Thanks for your pull request, @WalterBright!

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#16274"

@WalterBright WalterBright merged commit 5957736 into dlang:master Mar 1, 2024
46 of 48 checks passed
@WalterBright WalterBright deleted the tocsymFatal branch March 1, 2024 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Easy Review Refactoring No semantic changes to code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants