Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add building dmd with dub #15566

Merged
merged 2 commits into from
Feb 2, 2024
Merged

Add building dmd with dub #15566

merged 2 commits into from
Feb 2, 2024

Conversation

dkorpel
Copy link
Contributor

@dkorpel dkorpel commented Sep 1, 2023

Proof of concept, based on my DConf 23 lightning talk.

I don't want this to be a subpackage, but I presume removing the default 'targetType: none' and frontend dependency will break using dmd as a library by depending on "dmd".

Works on my Windows machine, I still need to test on Posix and add to CI.

@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @dkorpel! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#15566"

README.md Outdated
@@ -37,7 +37,13 @@ Refer to their respective `README.md` for more in-depth information.
| [compiler/samples](compiler/samples) | Various code examples |
| [druntime](druntime) | root of all runtime related code |

For more general information regarding compiling, installing, and
With a pre-built D compiler and dub installed, dmd can be built with:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
With a pre-built D compiler and dub installed, dmd can be built with:
With a D compiler and dub installed, dmd can be built with:

@maxhaton
Copy link
Member

maxhaton commented Sep 1, 2023

@Geod24

dub.sdl Outdated
importPaths "compiler/src"
stringImportPaths "compiler/src/dmd/res" "."
dflags "-L/STACK:16777216" platform="windows"
preGenerateCommands "cat -n /etc > SYSCONFDIR.imp" platform="posix"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can it invoke a single step from build.d

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know, the goal is to move away from build.d

@dkorpel dkorpel marked this pull request as ready for review February 2, 2024 12:26
Co-authored-by: Mathias LANG <[email protected]>
@Geod24 Geod24 merged commit cca753a into dlang:master Feb 2, 2024
48 checks passed
@dkorpel dkorpel deleted the build-with-dub branch February 2, 2024 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants