-
-
Notifications
You must be signed in to change notification settings - Fork 369
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Bugzilla 14945 - unions are missing from the ABI page #3915
base: master
Are you sure you want to change the base?
Conversation
Thanks for your pull request and interest in making D better, @ntrel! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please see CONTRIBUTING.md for more information. If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment. Bugzilla references
|
@@ -176,7 +176,18 @@ $(H2 $(LNAME2 struct_layout, Struct Layout)) | |||
the first field and the start of the object. | |||
) | |||
|
|||
$(P Structs with no fields of non-zero size (aka $(I Empty Structs)) have a size of one byte.) | |||
$(P $(DDSUBLINK spec/attribute, linkage, `extern(D)`) structs with no fields of non-zero |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Avoid the double negation “no … with non-…” and instead use “all … with …”.
$(P $(DDSUBLINK spec/attribute, linkage, `extern(D)`) structs with no fields of non-zero | |
$(P $(DDSUBLINK spec/attribute, linkage, `extern(D)`) structs with all fields of zero |
Mathematically speaking, any all statement about things is vacuously true if there are none. Most people who read this part of the spec will understand it, but if you’re in doubt, you could do this instead:
$(P $(DDSUBLINK spec/attribute, linkage, `extern(D)`) structs with no fields of non-zero | |
$(P $(DDSUBLINK spec/attribute, linkage, `extern(D)`) structs with no fields or all fields of zero |
$(P Conforms to the target's C ABI struct layout.) | ||
$(P These conform to the target's C ABI struct layout, except:) | ||
|
||
* An `extern(D)` struct or union with no fields has size 1, not 0. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also extern(C++)
structs seem to have non-zero size judging by running a simple example. The C++ Standard (all versions) agrees with that.
* An `extern(D)` struct or union with no fields has size 1, not 0. | |
* An `extern(D)` or `extern(C++)` struct or union with no fields has size 1, not 0. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This paragraph is about differences from C. The link that follows is for further information.
extern(C) struct C {} | ||
struct D {} | ||
|
||
static assert(C.sizeof == 0); | ||
static assert(D.sizeof == 1); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might be worth adding an extern(C++)
example.
extern(C) struct C {} | |
struct D {} | |
static assert(C.sizeof == 0); | |
static assert(D.sizeof == 1); | |
extern(C) struct C {} | |
extern(C++) struct Cpp {} | |
struct D {} | |
static assert(C.sizeof == 0); | |
static assert(Cpp.sizeof == 1); | |
static assert(D.sizeof == 1); |
Also list empty struct size and add example.