Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[spec/lex] Optional IdentifierStart after string/numeric literal suffix #3646

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ntrel
Copy link
Contributor

@ntrel ntrel commented Jun 22, 2023

This is for dlang/dmd#15339.

I have ignored the ImaginarySuffix FloatLiteral variants, as they are deprecated.

@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @ntrel! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

@dkorpel
Copy link
Contributor

dkorpel commented Jun 23, 2023

In the other PR you said:

More importantly, we can never add any new literal suffixes without breaking code if we don't have an error.

When you only put IdentifierStartError after existing suffixes, you still can't add new suffixes without breaking code.

@ntrel
Copy link
Contributor Author

ntrel commented Jun 23, 2023

Yes, this change will only catch existing suffixes running into an identifier. The more general errors could be done afterwards - now there's a way to handle them in the grammar.

This is for dlang/dmd#15339.

I have ignored the ImaginarySuffix FloatLiteral variants,
as they are deprecated.
@ntrel ntrel marked this pull request as ready for review July 14, 2023 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants