-
-
Notifications
You must be signed in to change notification settings - Fork 368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Primary Type Syntax #3616
base: master
Are you sure you want to change the base?
Primary Type Syntax #3616
Conversation
Thanks for your pull request and interest in making D better, @Bolpat! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please see CONTRIBUTING.md for more information. If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment. Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These two changes seem a bit unrelated to me, but they're small enough that I don't think demanding two separate PRs would be a good idea. And I think both of the changes are themselves correct.
In the grammar, I use
?
to signify optional occurrence.Parameter: ParameterDeclaration ParameterDeclaration ... ParameterDeclaration = AssignExpression ParameterDeclaration: ParameterAttributes? BasicType Declarator + ParameterAttributes? LinkageAttribute ref? TypeCtors? BasicType Declarator ParameterAttributes? Type Declarator: TypeSuffixes? Identifier
(After renaming the branch, this is the same as #3446.)