Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Primary Type Syntax #3616

Open
wants to merge 16 commits into
base: master
Choose a base branch
from
Open

Primary Type Syntax #3616

wants to merge 16 commits into from

Conversation

Bolpat
Copy link
Contributor

@Bolpat Bolpat commented May 26, 2023

In the grammar, I use ? to signify optional occurrence.

    FunctionLiteral:
-       function RefOrAutoRef? Type? ParameterWithAttributes? FunctionLiteralBody
-       delegate RefOrAutoRef? Type? ParameterWithMemberAttributes? FunctionLiteralBody
+       function LinkageAttribute? RefOrAutoRef? Type? ParameterWithAttributes? FunctionLiteralBody
+       delegate LinkageAttribute? RefOrAutoRef? Type? ParameterWithMemberAttributes? FunctionLiteralBody
    Type:
        TypeCtors? BasicType TypeSuffixes?
+       TypeCtors? ref TypeCtors? BasicType TypeSuffixes
+       TypeCtors? LinkageAttribute ref? TypeCtors? BasicType TypeSuffixes

    BasicType:
        FundamentalType
        . QualifiedIdentifier
        QualifiedIdentifier
        Typeof
        Typeof . QualifiedIdentifier
-       TypeCtor ( Type )
+       TypeCtor? ( Type )
        Vector
        TraitsExpression
        MixinType

    TypeSuffixes:
        TypeSuffix TypeSuffixes?

    TypeSuffix:
        *
        [ ]
        [ AssignExpression ]
        [ AssignExpression .. AssignExpression ]
        [ Type ]
        delegate Parameters MemberFunctionAttributes?
        function Parameters FunctionAttributes?
    Parameter:
        ParameterDeclaration
        ParameterDeclaration ...
        ParameterDeclaration = AssignExpression

    ParameterDeclaration:
        ParameterAttributes? BasicType Declarator
+       ParameterAttributes? LinkageAttribute ref? TypeCtors? BasicType Declarator
        ParameterAttributes? Type

    Declarator: 
        TypeSuffixes? Identifier

(After renaming the branch, this is the same as #3446.)

@dlang-bot
Copy link
Contributor

dlang-bot commented May 26, 2023

Thanks for your pull request and interest in making D better, @Bolpat! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

⚠️⚠️⚠️ Warnings ⚠️⚠️⚠️

  • In preparation for migrating from Bugzilla to GitHub Issues, the issue reference syntax has changed. Please add the word "Bugzilla" to issue references. For example, Fix Bugzilla Issue 12345 or Fix Bugzilla 12345.(Reminder: the edit needs to be done in the Git commit message, not the GitHub pull request.)

Bolpat added a commit to Bolpat/dlang.org that referenced this pull request May 30, 2023
Copy link
Contributor

@dukc dukc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These two changes seem a bit unrelated to me, but they're small enough that I don't think demanding two separate PRs would be a good idea. And I think both of the changes are themselves correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants