Fix build on OpenBSD, NetBSD and DragonflyBSD #769
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added extra version statements for OpenBSD, NetBSD and DragonflyBSD, as these are not included in the BSD version identifier. Also removed the line `SHELL:=/usr/bin/env bash' from the top of the makefile because most BSDs don't include bash in the base system, and the build doesn't need it anyway. On OpenBSD, using -inline with dmd causes the compiler to crash because of insufficient memory (with 8 GB), so I added a couple of ifneq's to use -inline only if the build is not running on OpenBSD.
|
DCD BUILD FAILED Build statistics: statistics (-before, +after)
client size=1052640 bin/dcd-client
-server size=3102144 bin/dcd-server
-rough build time=66s
+server size=3102400 bin/dcd-server
+rough build time=67s
-DCD run_tests.sh Elapsed (wall clock) time (h:mm:ss or m:ss): 0:08.08
-DCD run_tests.sh Maximum resident set size (kbytes): 34060
+DCD run_tests.sh Elapsed (wall clock) time (h:mm:ss or m:ss): 0:08.06
+DCD run_tests.sh Maximum resident set size (kbytes): 44276
short requests: (240x)
- min request time = 0.013ms
- 10th percentile = 0.145ms
- median time = 0.395ms
- 90th percentile = 0.663ms
- max request time = 1.726ms
+ min request time = 0.011ms
+ 10th percentile = 0.142ms
+ median time = 0.387ms
+ 90th percentile = 0.647ms
+ max request time = 1.597ms
long requests over 10ms: (51x)
- min request time = 13.723ms
- 10th percentile = 14.301ms
- median time = 15.807ms
- 90th percentile = 18.488ms
- max request time = 22.434ms
+ min request time = 12.501ms
+ 10th percentile = 13.155ms
+ median time = 14.953ms
+ 90th percentile = 17.752ms
+ max request time = 22.007ms
top 5 GC sources in server:Full build output |
WebFreak001
approved these changes
Dec 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added extra version statements for OpenBSD, NetBSD and DragonflyBSD, as these are not included in the BSD version identifier.
Also removed the line
SHELL:=/usr/bin/env bashfrom the top of the makefile because most BSDs don't include bash in the base system, and the build doesn't need it anyway.On OpenBSD, using -inline with dmd causes the compiler to crash because of insufficient memory (with 8 GB), so I added a couple of ifneq's to use -inline only if the build is not running on OpenBSD (or we could just remove -inline entirely...)