remove support for UTF-16 and UTF-32 #335
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UTF-16 and UTF-32 are so rarely used that the YAML devs are considering removing them from the spec entirely. For those who DO need this functionality,
std.utf.toUTF8/toUTF16/toUTF32
covers it just as efficiently - we were eagerly converting under the hood anyways.Notable public interface changes here:
Loader.fromBuffer
is now a deprecated alias ofLoader.fromString
as they are effectively equivalent now.void[]
orubyte[]
cannot directly be loaded anymore. I've only seen one public codebase even using this functionality, and it had to cast strings toubyte[]
to do it.toUTF8()
was removed. Why was this public in the first place...?Pros:
Cons: