Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revamp exception handling #329

Merged
merged 1 commit into from
May 30, 2024

Conversation

Herringway
Copy link
Member

This is pretty big, but a large chunk of it is unittests. This makes exceptions thrown by the library much more consistent as well as allowing them to provide additional context. A later PR will enable the test suite to take advantage of this new capability as well.

Copy link

codecov bot commented Mar 22, 2024

Codecov Report

Attention: Patch coverage is 93.93140% with 23 lines in your changes are missing coverage. Please review.

Project coverage is 93.73%. Comparing base (8b18bb0) to head (bd74554).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #329      +/-   ##
==========================================
- Coverage   93.74%   93.73%   -0.02%     
==========================================
  Files          29       29              
  Lines        4570     4770     +200     
==========================================
+ Hits         4284     4471     +187     
- Misses        286      299      +13     
Files Coverage Δ
source/dyaml/composer.d 97.87% <100.00%> (+1.12%) ⬆️
source/dyaml/loader.d 95.60% <100.00%> (+1.23%) ⬆️
source/dyaml/node.d 91.07% <ø> (-0.78%) ⬇️
source/dyaml/parser.d 98.85% <100.00%> (+0.08%) ⬆️
source/dyaml/representer.d 99.48% <ø> (ø)
source/dyaml/scanner.d 100.00% <100.00%> (+0.34%) ⬆️
source/dyaml/test/reader.d 75.00% <ø> (ø)
source/dyaml/reader.d 96.60% <80.00%> (-0.86%) ⬇️
source/dyaml/constructor.d 94.05% <93.00%> (+1.68%) ⬆️
source/dyaml/exception.d 68.29% <67.50%> (-22.62%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8b18bb0...bd74554. Read the comment docs.

@Herringway Herringway merged commit ba5a932 into dlang-community:master May 30, 2024
7 of 8 checks passed
@Herringway Herringway deleted the exception-reorg branch May 30, 2024 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant