Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add BaseAnalyzerArguments to keep ctor changes sane #939

Merged
merged 2 commits into from
Oct 25, 2023

Conversation

WebFreak001
Copy link
Member

also immediately makes tokens a part of it

This struct can for example precompute token indices for line endings.

I think this cleans up a little code debt and also allows automatic construction for most analyzers (not done in this PR) and with that also a cleaner way of introspecting configuration in the future for the INI config and passing it in through the constructor automatically.

The tokens array is available in each analyzer now, allowing to implement helper methods that operate with those, such as the diagnostic helpers.

also immediately makes tokens a part of it

This struct can for example precompute token indices for line endings
@WebFreak001 WebFreak001 merged commit 8612841 into dlang-community:master Oct 25, 2023
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant