Fix to work in place-with-space #120
Conversation
There was a problem hiding this comment.
d77ad82: 3-arg open is a good idea, thank you. I don't see a point though changing from open(FH) to open(my $fh) other than style, but I can live with that. However there's some namings that are lost, f ex open(PRIMADEF) vs open(my $fh), I'd like to keep original variable names where they make sense
There was a problem hiding this comment.
42e7815: The idea is solid but I don't understand why if I run new Makefile.PL under linux I get paths double-quoted. I think that while accounting for special characters is great, it should be done with care, no quoting if necessary . And the proper quote characters depending on the OS
(hint: there's $SHQUOTE variable available specifically for this)
An approach you could do another time - if there's one or several commit(s) you're happy to accept, you could just cherry-pick it/them straight onto |
mohawk2
force-pushed
the
fix-in-space
branch
2 times, most recently
from
a0bfc5d to
9ebb8fc
Compare
mohawk2
force-pushed
the
fix-in-space
branch
from
9ebb8fc to
106b610
Compare
|
I believe I've addressed all the points you've raised. Please let me know if not! |
|
looks great, thank you! |
Also has 3-arg open, and clean up more files on
make clean.