Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a memory leak due to captured strong self and a retain cycle #28

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix a memory leak due to captured strong self and a retain cycle #28

wants to merge 1 commit into from

Conversation

devinlane
Copy link

  • Don't use self in a capturing block
  • Use weak for an unowned object

Fix a memory leak due to captured strong self and a retain cycle
5a982d2 
- Don't use `self` in a capturing block
- Use `weak` for an unowned object
@devinlane
Copy link
Author

With this change I no longer leak DJILiveViewRenderContext and DJILiveViewRenderProgram objects after using the video previewer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@devinlane