Fix all errors and made a lot of class internal

SynoAI.Tests/SynoAI.Tests.csproj

@@ -7,7 +7,7 @@
 		<IsPackable>false</IsPackable>
 		<ImplicitUsings>enable</ImplicitUsings>
 		<RestorePackagesWithLockFile>true</RestorePackagesWithLockFile>
-		<AnalysisLevel>latest-recommended</AnalysisLevel>
+		<AnalysisLevel>6.0-recommended</AnalysisLevel>
 	</PropertyGroup>
 
 	<PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Debug|AnyCPU'">

SynoAI/AIs/AI.cs

@@ -2,7 +2,7 @@
 
 namespace SynoAI.AIs
 {
-    public abstract class AI
+    internal abstract class AI
     {
         public abstract Task<IEnumerable<AIPrediction>> Process(ILogger logger, Camera camera, byte[] image);
     }

SynoAI/AIs/DeepStack/DeepStackAI.cs

@@ -5,9 +5,9 @@
 
 namespace SynoAI.AIs.DeepStack
 {
-    public class DeepStackAI : AI
+    internal class DeepStackAI : AI
     {
-        public async override Task<IEnumerable<AIPrediction>> Process(ILogger logger, Camera camera, byte[] image)
+        public override async Task<IEnumerable<AIPrediction>> Process(ILogger logger, Camera camera, byte[] image)
         {
             Stopwatch stopwatch = Stopwatch.StartNew();
 
@@ -69,7 +69,7 @@ public async override Task<IEnumerable<AIPrediction>> Process(ILogger logger, Ca
         /// <param name="basePath"></param>
         /// <param name="resourcePath"></param>
         /// <returns>A <see cref="Uri"/> for the combined base and resource.</returns>
-        protected Uri GetUri(string basePath, string resourcePath)
+        protected static Uri GetUri(string basePath, string resourcePath)
         {
             Uri baseUri = new(basePath);
             return new Uri(baseUri, resourcePath);
@@ -82,7 +82,7 @@ protected Uri GetUri(string basePath, string resourcePath)
         /// <param name="message">The message to parse.</param>
         /// <param name="logger"></param>
         /// <returns>A usable object.</returns>
-        private async Task<DeepStackResponse> GetResponse(ILogger logger, Camera camera, HttpResponseMessage message)
+        private static async Task<DeepStackResponse> GetResponse(ILogger logger, Camera camera, HttpResponseMessage message)
         {
             string content = await message.Content.ReadAsStringAsync();                
             logger.LogDebug($"{camera.Name}: DeepStackAI: Responded with {content}.");

SynoAI/App/HttpClientWrapper.cs

@@ -1,6 +1,6 @@
 namespace SynoAI.App
 {
-    public class HttpClientWrapper : HttpClient, IHttpClient
+    internal class HttpClientWrapper : HttpClient, IHttpClient
     {
     }
 }

SynoAI/App/Shared.cs

@@ -1,6 +1,6 @@
 namespace SynoAI.App
 {
-    public static class Shared
+    internal static class Shared
     {
         public static IHttpClient HttpClient = new HttpClientWrapper();
     }

SynoAI/Config.cs

@@ -8,7 +8,7 @@ namespace SynoAI
     /// <summary>
     /// Represents the system configuration.
     /// </summary>
-    public static class Config
+    internal static class Config
     {
         /// <summary>
         /// The URL to the synology API.

SynoAI/Constants.cs

@@ -1,6 +1,6 @@
 namespace SynoAI
 {
-    public static class Constants
+    internal static class Constants
     {
         public const string DIRECTORY_CAPTURES = "Captures";
     }

SynoAI/Controllers/CameraController.cs

@@ -182,8 +182,8 @@ public async void Get(string id)
 
                     // Save the original unprocessed image if required
                     if (Config.SaveOriginalSnapshot == SaveSnapshotMode.Always ||
-                        (Config.SaveOriginalSnapshot == SaveSnapshotMode.WithPredictions && predictions.Count() > 0) ||
-                        (Config.SaveOriginalSnapshot == SaveSnapshotMode.WithValidPredictions && validPredictions.Count() > 0))
+                        (Config.SaveOriginalSnapshot == SaveSnapshotMode.WithPredictions && predictions.Any()) ||
+                        (Config.SaveOriginalSnapshot == SaveSnapshotMode.WithValidPredictions && validPredictions.Any()))
                     {
                         _logger.LogInformation($"{id}: Saving original image");
                         SnapshotManager.SaveOriginalImage(_logger, camera, snapshot);
@@ -271,7 +271,7 @@ public void Post(string id, [FromBody]CameraOptionsDto options)
         private bool ShouldIncludePrediction(string id, Camera camera, Stopwatch overallStopwatch, AIPrediction prediction)
         {
             // Check if the prediction falls within the exclusion zones
-            if (camera.Exclusions != null && camera.Exclusions.Count() > 0)
+            if (camera.Exclusions != null && camera.Exclusions.Any())
             {
                 Rectangle boundary = new(prediction.MinX, prediction.MinY, prediction.SizeX, prediction.SizeY);
                 foreach (Zone exclusion in camera.Exclusions)
@@ -390,7 +390,7 @@ private byte[] PreProcessSnapshot(Camera camera, byte[] snapshot)
         /// <param name="bitmap">The bitmap to rotate.</param>
         /// <param name="angle">The angle to rotate to.</param>
         /// <returns>The rotated bitmap.</returns>
-        private SKBitmap Rotate(SKBitmap bitmap, double angle)
+        private static SKBitmap Rotate(SKBitmap bitmap, double angle)
         {
             double radians = Math.PI * angle / 180;
             float sine = (float)Math.Abs(Math.Sin(radians));

SynoAI/Controllers/HomeController.cs

@@ -253,7 +253,7 @@ private static int GetObjects(string filename)
             if (index != -1)
             {
                 //try to extract the number of valid objects predicted inside this snapshot
-                if (!int.TryParse(name.Substring(index + 1), out objects))
+                if (!int.TryParse(name.AsSpan(index + 1), out objects))
                     objects = 0;
             }
             else

SynoAI/Extensions/StringExtensions.cs

@@ -1,13 +1,13 @@
 namespace SynoAI.Extensions
 {
-    public static class StringExtensions
+    internal static class StringExtensions
     {
         public static string FirstCharToUpper(this string input) =>
             input switch
             {
                 null => throw new ArgumentNullException(nameof(input)),
                 "" => throw new ArgumentException($"{nameof(input)} cannot be empty", nameof(input)),
-                _ => input.First().ToString().ToUpper() + input.Substring(1)
+                _ => string.Concat(input.First().ToString().ToUpper(), input.AsSpan(1))
             };
     }
 }

SynoAI/Models/Camera.cs

@@ -115,6 +115,7 @@ public int GetDelayAfterSuccess()
             return DelayAfterSuccess ?? Config.DelayAfterSuccess ?? GetDelay();
         }
 
+        /// <inheritdoc />
         public override string ToString()
         {
             return Name;

SynoAI/Models/CameraQuality.cs

@@ -1,6 +1,6 @@
 namespace SynoAI.Models
 {
-    public enum CameraQuality
+    internal enum CameraQuality
     {
         High = 0,
         Balanced = 1,

SynoAI/Models/Notification.cs

@@ -2,7 +2,7 @@
 
 namespace SynoAI.Models
 {
-    public class Notification
+    internal class Notification
     {
         /// <summary>
         /// Object for fetching the processed image

SynoAI/Models/ProcessedImage.cs

@@ -14,6 +14,11 @@ public class ProcessedImage
         /// </summary>
         public readonly string FileName;
 
+        /// <summary>
+        /// Create a ProcessedImage
+        /// </summary>
+        /// <param name="filePath"></param>
+        /// <exception cref="ArgumentNullException">When filePath is null</exception>
         public ProcessedImage(string filePath)
         {
             if (string.IsNullOrWhiteSpace(filePath)) throw new ArgumentNullException(nameof(filePath));

SynoAI/Models/SaveSnapshotMode.cs

@@ -1,6 +1,6 @@
 namespace SynoAI.Models
 {
-    public enum SaveSnapshotMode
+    internal enum SaveSnapshotMode
     {
         /// <summary>
         /// The snapshots are never saved.

SynoAI/Models/SynologyApiInfoResponse.cs

@@ -1,6 +1,6 @@
 namespace SynoAI.Models
 {
-    public class SynologyApiInfoResponse : Dictionary<string, SynologyApiInfo>
+    internal class SynologyApiInfoResponse : Dictionary<string, SynologyApiInfo>
     {
     }
 }

SynoAI/Models/SynologyCameras.cs

@@ -1,6 +1,6 @@
 namespace SynoAI.Models
 {
-    public class SynologyCameras
+    internal class SynologyCameras
     {
         public IEnumerable<SynologyCamera> Cameras { get; set; }
     }

SynoAI/Models/SynologyError.cs

@@ -1,6 +1,6 @@
 namespace SynoAI.Models
 {
-    public class SynologyError
+    internal class SynologyError
     {
         public string Code { get; set; }
     }

SynoAI/Models/SynologyLogin.cs

@@ -1,6 +1,6 @@
 namespace SynoAI.Models
 {
-    public class SynologyLogin
+    internal class SynologyLogin
     {
         public string SID { get; set; }
     }

SynoAI/Models/SynologyResponse.cs

@@ -1,11 +1,11 @@
 namespace SynoAI.Models
 {
-    public class SynologyResponse<T> : SynologyResponse
+    internal class SynologyResponse<T> : SynologyResponse
     {
         public T Data { get; set; }
     }
 
-    public class SynologyResponse
+    internal class SynologyResponse
     {
         public bool Success { get; set; }
         public SynologyError Error { get; set; }

SynoAI/Notifiers/Discord/Discord.cs

@@ -3,7 +3,7 @@
 
 namespace SynoAI.Notifiers.Discord
 {
-    public class Discord : NotifierBase
+    internal class Discord : NotifierBase
     {
         /// <summary>
         /// Discord Webhook Url.
@@ -25,7 +25,7 @@ public override async Task SendAsync(Camera camera, Notification notification, I
             HttpResponseMessage responseMessage = await Shared.HttpClient.PostAsync(Url, formData);
             if (responseMessage.IsSuccessStatusCode)
             {
-                logger.LogInformation($"{camera.Name}: Discord: Notification sent successfully");
+                logger.LogInformation("{CameraName}: Discord: Notification sent successfully", camera.Name);
             }
             else
             {

SynoAI/Notifiers/Discord/DiscordFactory.cs

@@ -1,6 +1,6 @@
 namespace SynoAI.Notifiers.Discord
 {
-    public class DiscordFactory : NotifierFactory
+    internal class DiscordFactory : NotifierFactory
     {
         public override INotifier Create(ILogger logger, IConfigurationSection section)
         {

SynoAI/Notifiers/Email/Email.cs

@@ -8,7 +8,7 @@ namespace SynoAI.Notifiers.Email
     /// <summary>
     /// Calls a third party API.
     /// </summary>
-    public class Email : NotifierBase
+    internal class Email : NotifierBase
     {
         /// <summary>
         /// The email address to send the notification from.

SynoAI/Notifiers/Email/EmailFactory.cs

@@ -2,7 +2,7 @@
 
 namespace SynoAI.Notifiers.Email
 {
-    public class EmailFactory : NotifierFactory
+    internal class EmailFactory : NotifierFactory
     {
         public override INotifier Create(ILogger logger, IConfigurationSection section)
         {
@@ -31,7 +31,7 @@ public override INotifier Create(ILogger logger, IConfigurationSection section)
             }
         }
 
-        private SecureSocketOptions GetSecureSocketOptions(ILogger logger, IConfigurationSection section)
+        private static SecureSocketOptions GetSecureSocketOptions(ILogger logger, IConfigurationSection section)
         {
             string options = section.GetValue<string>("Encryption", "None").ToUpper();
 

SynoAI/Notifiers/INotifier.cs

@@ -2,7 +2,7 @@
 
 namespace SynoAI.Notifiers
 {
-    public interface INotifier
+    internal interface INotifier
     {
         /// <summary>
         /// The list of camera names that the notifier is for.

SynoAI/Notifiers/Mqtt/Mqtt.cs

@@ -7,7 +7,7 @@ namespace SynoAI.Notifiers.Mqtt
     /// <summary>
     /// Sends a message over MQTT.
     /// </summary>
-    public sealed class Mqtt : NotifierBase
+    internal sealed class Mqtt : NotifierBase
     {
         /// <summary>
         /// The username when using Basic authentication.

SynoAI/Notifiers/Mqtt/MqttFactory.cs

@@ -1,6 +1,6 @@
 namespace SynoAI.Notifiers.Mqtt
 {
-    public class MqttFactory : NotifierFactory
+    internal class MqttFactory : NotifierFactory
     {
         public override INotifier Create(ILogger logger, IConfigurationSection section)
         {

SynoAI/Notifiers/NotifierBase.cs

@@ -4,7 +4,7 @@
 
 namespace SynoAI.Notifiers
 {
-    public abstract class NotifierBase : INotifier
+    internal abstract class NotifierBase : INotifier
     {
         public IEnumerable<string> Cameras { get; set; } 
         public IEnumerable<string> Types { get; set; } 
@@ -16,7 +16,7 @@ public abstract class NotifierBase : INotifier
 
         public virtual Task CleanupAsync(ILogger logger) { return Task.CompletedTask; }
 
-        protected string GetMessage(Camera camera, IEnumerable<string> foundTypes, string errorMessage = null)
+        protected static string GetMessage(Camera camera, IEnumerable<string> foundTypes, string errorMessage = null)
         {
             string result ;
             if (Config.AlternativeLabelling && Config.DrawMode == DrawMode.Matches)
@@ -53,7 +53,7 @@ protected string GetMessage(Camera camera, IEnumerable<string> foundTypes, strin
             return result;
         }
 
-        protected string GetImageUrl(Camera camera, Notification notification)
+        protected static string GetImageUrl(Camera camera, Notification notification)
         {
             if (Config.SynoAIUrL == null)
             {
@@ -69,7 +69,7 @@ protected string GetImageUrl(Camera camera, Notification notification)
         /// <summary>
         /// Generates a JSON representation of the notification.
         /// </summary>
-        protected string GenerateJSON(Camera camera, Notification notification, bool sendImage)
+        protected static string GenerateJSON(Camera camera, Notification notification, bool sendImage)
         {
             dynamic jsonObject = new ExpandoObject();
 
@@ -95,7 +95,7 @@ protected string GenerateJSON(Camera camera, Notification notification, bool sen
         /// <summary>
         /// Returns FileStream data as a base64-encoded string
         /// </summary>
-        private string ToBase64String(FileStream fileStream)
+        private static string ToBase64String(FileStream fileStream)
         {
             byte[] buffer = new byte[fileStream.Length];
             fileStream.Read(buffer, 0, (int)fileStream.Length);
@@ -108,7 +108,7 @@ private string ToBase64String(FileStream fileStream)
         /// </summary>
         /// <param name="message">The message to parse.</param>
         /// <returns>A usable object.</returns>
-        protected async Task<T> GetResponse<T>(HttpResponseMessage message)
+        protected static async Task<T> GetResponse<T>(HttpResponseMessage message)
         {
             string content = await message.Content.ReadAsStringAsync();
             return JsonConvert.DeserializeObject<T>(content);

SynoAI/Notifiers/NotifierFactory.cs

@@ -12,7 +12,7 @@ namespace SynoAI.Notifiers
     /// <summary>
     /// Handles the construction of the notifiers.
     /// </summary>
-    public abstract class NotifierFactory
+    internal abstract class NotifierFactory
     {
         public abstract INotifier Create(ILogger logger, IConfigurationSection section);
 

SynoAI/Notifiers/Pushbullet/Pushbullet.cs

@@ -8,7 +8,7 @@ namespace SynoAI.Notifiers.Pushbullet
     /// Configuration for sending a Pushbullet notification.
     /// https://docs.pushbullet.com/
     /// </summary>
-    public class Pushbullet : NotifierBase
+    internal class Pushbullet : NotifierBase
     {
         //private const int MAX_FILE_SIZE = 26214400;
 

SynoAI/Notifiers/Pushbullet/PushbulletError.cs

@@ -1,6 +1,6 @@
 namespace SynoAI.Notifiers.Pushbullet
 {
-    public class PushbulletError
+    internal class PushbulletError
     {
         public string Code { get; set; }
         public string Type { get; set; }

SynoAI/Notifiers/Pushbullet/PushbulletErrorResponse.cs

@@ -2,7 +2,7 @@
 
 namespace SynoAI.Notifiers.Pushbullet
 {
-    public class PushbulletErrorResponse
+    internal class PushbulletErrorResponse
     {
         public PushbulletError Error { get; set; }
         [JsonProperty("error_code")]