Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve nrepl test reporting #257

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Improve nrepl test reporting #257

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 20 additions & 7 deletions src/portal/nrepl.clj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,26 +111,39 @@
(catch Exception _))
transport))

(def ^:private ^:dynamic *test-report* nil)

(defmulti ^:dynamic report (constantly :default))

(defmethod report :default [message]
(when *test-report*
(swap! *test-report* conj message))
(when-let [f (get-method report (:type message))]
(f message)))

(defn- add-method [^clojure.lang.MultiFn multifn dispatch-val f]
(.addMethod multifn dispatch-val f))

(doseq [[dispatch-value f] (methods test/report)]
(add-method report dispatch-value f))

(defn- wrap-portal* [handler msg]
(let [report (atom [])
test-report test/report
portal-report (fn [value]
(swap! report conj value)
(test-report value))]
(let [test-report (atom [])]
(handler
(cond-> msg
(#{"eval" "load-file"} (:op msg))
(-> (update :transport
->PortalTransport
(assoc msg
:report report
:report test-report
:stdio (atom [])
:start (System/nanoTime)
:time (Date.)))
(update :session
(fn [session]
(swap! session assoc
#'test/report portal-report)
#'test/report report
#'*test-report* test-report)
session)))))))

(defn wrap-portal
Expand Down
Loading