add docker-compose + misc. irc bot changes (see commit msg) #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For some odd reason, it didn't seem to work when I started the web container -- not sure why -- it started but I guess didn't get to the binding stage? not sure...in either case so long as the elasticsearch container is started prior to the web container, things work fine. |
robbyoconnor
force-pushed
the
add-docker-compose
branch
5 times, most recently
from
b922f01 to
94dfc65
Compare
robbyoconnor
changed the title
|
Ready for showtime |
robbyoconnor
force-pushed
the
add-docker-compose
branch
5 times, most recently
from
41622fa to
0f07ff6
Compare
|
I went ahead and updated the README as well. |
robbyoconnor
force-pushed
the
add-docker-compose
branch
3 times, most recently
from
d6bf3ed to
d2dbbcd
Compare
robbyoconnor
changed the title
robbyoconnor
force-pushed
the
add-docker-compose
branch
2 times, most recently
from
2105a0f to
d813821
Compare
robbyoconnor
changed the title
robbyoconnor
force-pushed
the
add-docker-compose
branch
2 times, most recently
from
b34469b to
4597655
Compare
|
@djazayeri, in addition to adding docker-compose, I refactored the bot a bit: It will only say it's on the channel, when it's on the channel, hooking into the event triggered when NAMES is received from the server. |
robbyoconnor
force-pushed
the
add-docker-compose
branch
5 times, most recently
from
45148c2 to
cd318be
Compare
|
There is a vulnerability in moment.js -- also went ahead and updated that. |
robbyoconnor
force-pushed
the
add-docker-compose
branch
10 times, most recently
from
aa15efd to
b288d81
Compare
|
Okay -- I think I'm done :) |
robbyoconnor
force-pushed
the
add-docker-compose
branch
4 times, most recently
from
9db0212 to
15fca4e
Compare
|
Final tally of changes:
|
robbyoconnor
force-pushed
the
add-docker-compose
branch
3 times, most recently
from
2c53ac6 to
0587f76
Compare
|
@djazayeri, I cleaned this up -- made it so it waits for elasticsearch to come up before starting the node app; I also updated this to use version 2 of the docker-compose file format. Also resolved a merge conflict and rebased. |
robbyoconnor
force-pushed
the
add-docker-compose
branch
from
0587f76 to
bcf70db
Compare
robbyoconnor
force-pushed
the
add-docker-compose
branch
from
bcf70db to
b90b0d7
Compare
robbyoconnor
force-pushed
the
add-docker-compose
branch
from
b90b0d7 to
a023e59
Compare
- Update Node to Node 5.x - Add docker compose for easier provisioning - Add userName and realName for the bot - Wait until the bot is connected to log the channel it is on - Address a security vulnerability in moment.js - Add david-dm.org badge to track up to date packages and whether or not - they are vulnerable - Add travis-ci and add badge for travis-ci - Fix failing tests due to the upgrade to lodash 4 (pluck was removed)
robbyoconnor
force-pushed
the
add-docker-compose
branch
from
a023e59 to
b6dd3c5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I felt this might be handy to have. I provided for the case of production vs. development.