Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: sticky footer #419

Conversation

raffaellasuardini
Copy link
Contributor

Updated the footer to be a sticky one as requested

@tim-schilling
Copy link
Member

Could you add a screen shot of it on a page where you're partially scrolled down?

@tim-schilling
Copy link
Member

I've got no problems with the approach. Just want to see it work before merging.

@raffaellasuardini
Copy link
Contributor Author

Ok, let me know if this is what you're asking for.
The event page is the longest
Screenshot 2024-08-02 alle 17 41 10
The login page is the one with the smallest content
Screenshot 2024-08-02 alle 17 42 56

Copy link
Member

@tim-schilling tim-schilling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️ 🚀 👏

@tim-schilling tim-schilling merged commit 5fa91ce into djangonaut-space:develop Aug 2, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants