Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed #212 - Prevent partners in past events #220

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fixed #212 - Prevent partners in past events #220

wants to merge 1 commit into from

Conversation

PankajVishw50
Copy link
Contributor

Added filter to only allow community partners
which were created before the event while fetching partners in EventApiView.retrieve method

Closes #212

Changes

  • added filter in EventApiView.retrieve method
  • removed unused imports which were throwing lint errors

Type of change

  • Bug fix
  • Feature update
  • Breaking change
  • Documentation update

How has this been tested?

  • Manually

Author Checklist

  • Code has been commented, particularly in hard-to-understand areas
  • Changes generate no new warnings
  • Vital changes have been captured in unit and/or integration tests
  • New and existing unit tests pass locally with my changes
  • Documentation has been extended, if necessary
  • Merging to main from fork:issue_212

@PankajVishw50
Fixed djangoindia#212 - Prevent partners in past events
69d1074 
Added filter to only allow community partners
which were created before the event while fetching partners
in EventApiView.retrieve method
@DevilsAutumn
Copy link
Member

@PankajVishw50 Can you please rebase this PR to main?

@DevilsAutumn
Copy link
Member

@PankajVishw50 Do you have any updates on this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Saurabhsharma884 Saurabhsharma884 Awaiting requested review from Saurabhsharma884 Saurabhsharma884 is a code owner

@ankanchanda ankanchanda Awaiting requested review from ankanchanda ankanchanda is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Prevent community partners in past events
2 participants
@PankajVishw50 @DevilsAutumn