Lead by view port #243
Open
Lead by view port #243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding new property switch called 'leadByViewPort' to manage if the animation should only happen when the element is within the ViewPort area.
- Removing use of JQuery from the library as previous suggestion was using the $. dependency. - Also removing hardwire value referencing the id of an element.
Removing more $ dependencies
Removing formatting changes.
|
@moeamaya, here is the new PR as requested. Sorry, I just notice the accumulated commits are also here. I tried to remove the formatting changes by resetting the file and applying just my changes. However, if you just want to have one single commit I can remove all this and try to get the repo cloned again and start all over again. Just let me know. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enumerating changes in the rellax.js file: