Prio3 cleanups #1127
Merged
Prio3 cleanups #1127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ParallelSumMultithreaded only accelerates calls to eval_poly(), which is only used during sharding.
cjpatton
approved these changes
Oct 31, 2024
inahga
approved these changes
Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This cleans up a couple things I noticed while reviewing #1123. We no longer need a polyfill for
usize::ilog2(), because our MSRV is currently 1.71, and I corrected the documentation of the rayon-accelerated VDAF types. We only parallelizeeval_poly()calls to the parallel sum gadget, thus only sharding is sped up. (preparation just needseval()from this gadget, which doesn't require any NTTs)