Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

validate vdaf and query type are supported by both aggregators #359

Merged
merged 2 commits into from
Aug 1, 2023
Merged

validate vdaf and query type are supported by both aggregators #359

merged 2 commits into from
Aug 1, 2023

Conversation

jbr
Copy link
Contributor

@jbr jbr commented Jul 31, 2023 •
edited
Loading

closes #341

@jbr jbr requested a review from a team as a code owner July 31, 2023 21:49
jbr
jbr commented Jul 31, 2023
View reviewed changes
src/entity/task/new_task.rs Outdated
match errors.errors_mut().entry("vdaf").or_insert_with(|| {
ValidationErrorsKind::Struct(Box::new(ValidationErrors::new()))
}) {
ValidationErrorsKind::Struct(errors) => {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this awkwardness is due to the validate crate, and I'm increasingly itching to just drop it

github-advanced-security[bot]
github-advanced-security bot found potential problems Jul 31, 2023
View reviewed changes
src/entity/task/new_task.rs Fixed Show fixed Hide fixed
src/entity/task/new_task.rs Fixed Show fixed Hide fixed
@jbr jbr force-pushed the validate-vdaf-and-query-type-are-supported-by-both-aggregators branch from efd16e2 to 0e0dce0 Compare July 31, 2023 21:55
@jbr jbr force-pushed the validate-vdaf-and-query-type-are-supported-by-both-aggregators branch from e18c27d to ebff455 Compare July 31, 2023 23:40
@jbr jbr force-pushed the validate-vdaf-and-query-type-are-supported-by-both-aggregators branch from ebff455 to 6e4651e Compare July 31, 2023 23:44
@jbr jbr merged commit 905e2a5 into main Aug 1, 2023
6 checks passed
@jbr jbr deleted the validate-vdaf-and-query-type-are-supported-by-both-aggregators branch August 1, 2023 00:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@divergentdave divergentdave divergentdave approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@jbr @divergentdave