Add arrayofobjects feature #240

RayenRomdhane · 2023-10-23T14:22:34Z

No description provided.

Zorin95670 · 2023-10-24T12:00:28Z

src/models/ComponentAttributeDefinition.js

@@ -20,6 +20,9 @@ class ComponentAttributeDefinition {
   * @param {boolean} [props.required] - Attribute is required.
   * @param {ComponentAttributeDefinition[]} [props.definedAttributes] - Defined attributes for
   * this type.
+   * @param {ComponentAttributeDefinition[]} [props.itemDefinition] - Definition of the structure
+   * for individual array elements.
+   * @param {string} [props.itemType] - Type of individual array elements.


Missing explanation on, type we can set on and if defined type is Object an itemDefinition must be provided

Zorin95670 · 2023-10-24T12:02:00Z

src/models/ComponentAttribute.js

+
+        // eslint-disable-next-line valid-typeof
+        return this.value.some((item) => typeof item.value !== itemType);
+      }
    }

    // eslint-disable-next-line valid-typeof


remote this line

Zorin95670 · 2023-10-24T12:02:20Z

src/models/ComponentAttribute.js

-    if (this.definition.type === 'Link') {
-      return !Array.isArray(this.value) || this.value.some((link) => typeof link !== 'string');
-    }
+    let typeofvalue = typeof this.value;


why don't you need esilnt disable here ?

There was no eslint error so I didnt use it.

Zorin95670 · 2023-10-24T12:03:04Z

tests/unit/models/ComponentAttribute.spec.js

+        };
+        expect(componentAttribute.hasError()).toBeFalsy();
+
+        // componentAttribute.definition.rules.values = null;


remove this line

Zorin95670 · 2023-10-24T12:03:55Z

tests/unit/models/ComponentAttribute.spec.js

@@ -340,6 +347,39 @@ describe('Test class: ComponentAttribute', () => {

        componentAttribute.definition.rules.values = null;
      });
+      it('Check type array of object', () => {


rename to Check if item in array is valid
And add test to check hasError return false when itemtype are not valid

Zorin95670 · 2023-10-24T12:04:21Z

tests/unit/models/ComponentAttribute.spec.js

@@ -307,7 +307,10 @@ describe('Test class: ComponentAttribute', () => {
      it('Check if respect all conditions', () => {


Put test with according class (in commit)

Zorin95670 · 2023-10-24T12:05:35Z

changelog.md

@@ -4,6 +4,16 @@ All notable changes to this project will be documented in this file.

 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html)
+## [Unreleased]
+
+### Added


Missing guides migration update, to explain that now with have to set itemtype on Array type with some examples. Please read other migration guide to know how to write it.

Zorin95670 · 2023-10-24T12:05:51Z

changelog.md

@@ -4,6 +4,16 @@ All notable changes to this project will be documented in this file.

 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html)
+## [Unreleased]


missing break line before

Zorin95670 · 2023-10-24T12:06:25Z

changelog.md

+
+### Changed
+
+- Change `__typeOfValueValidation` in `ComponentAttribute`.


Explanation what chane is

Zorin95670 reviewed Oct 24, 2023

View reviewed changes

RayenRomdhane force-pushed the feature/add_arrayofobjects branch from a6fb187 to 1910d0c Compare October 31, 2023 10:30

RayenRomdhane force-pushed the feature/add_arrayofobjects branch from acf6835 to 790681a Compare December 12, 2023 10:28

RayenRomdhane and others added 4 commits December 12, 2023 11:39

add itemType and itemDefinition to ComponentAttributeDefinition

3d67798

add arrayofobjects validation

bae0b76

update changelog

fac649a

fix link issue with array of objects

7c1a9ee

RayenRomdhane force-pushed the feature/add_arrayofobjects branch from 790681a to 7c1a9ee Compare December 12, 2023 10:50

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add arrayofobjects feature #240

Add arrayofobjects feature #240

RayenRomdhane commented Oct 23, 2023

Zorin95670 Oct 24, 2023

RayenRomdhane Oct 31, 2023

Zorin95670 Oct 24, 2023

RayenRomdhane Oct 31, 2023

Zorin95670 Oct 24, 2023

RayenRomdhane Oct 30, 2023

Zorin95670 Oct 24, 2023

RayenRomdhane Oct 31, 2023

Zorin95670 Oct 24, 2023

RayenRomdhane Oct 31, 2023

Zorin95670 Oct 24, 2023

RayenRomdhane Oct 31, 2023

Zorin95670 Oct 24, 2023

RayenRomdhane Oct 31, 2023

Zorin95670 Oct 24, 2023

RayenRomdhane Oct 31, 2023

Zorin95670 Oct 24, 2023

RayenRomdhane Oct 31, 2023

		@@ -307,7 +307,10 @@ describe('Test class: ComponentAttribute', () => {
		it('Check if respect all conditions', () => {


		### Changed

		- Change `__typeOfValueValidation` in `ComponentAttribute`.

Add arrayofobjects feature #240

Are you sure you want to change the base?

Add arrayofobjects feature #240

Conversation

RayenRomdhane commented Oct 23, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment