Allow deletion of uploaded relay datasets #3512
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PBENCH-1238 As a stopgap for "final" Relay support under the agent, we plan to establish a known project Relay Server (e.g., on our AWS host) for testing. That server has limited storage, and substantial use. To avoid requiring constant manual management of space, our plan is to implement a mechanism to cause the Pbench Server to delete files from the Relay Server after intake, and to change the Pbench Dashboard relay action to always supply that option. Note that this PR adds the `?delete=t` to the dashboard *unconditionally*; in the future we can consider adding a checkbox to allow users to control the behavior, especially when they own a private relay server.
dbutenhof
added
Server
API
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PBENCH-1238
As a stopgap for "final" Relay support under the agent, we plan to establish a known project Relay Server (e.g., on our AWS host) for testing. That server has limited storage, and substantial use. To avoid requiring constant manual management of space, our plan is to implement a mechanism to cause the Pbench Server to delete files from the Relay Server after intake, and to change the Pbench Dashboard relay action to always supply that option. Note that this PR adds the
?delete=tto the dashboard unconditionally; in the future we can consider adding a checkbox to allow users to control the behavior, especially when they own a private relay server.