Don't emit logs before rollback()
#3125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When handling exceptions, certain kinds of exceptions in either
SQLAlchemy or in PyscoPG2 will cause references to the SQLAlchemy object
instance to cause other exceptions. For example, one might see:
sqlalchemy.exc.PendingRollbackError: This Session's transaction has
been rolled back due to a previous exception during flush. To begin
a new transaction with this Session, first issue Session.rollback().
By moving the log messages after the `rollback()` call, we avoid the
extra mess caused.
We also use the `self.logger` where possible, and we enhance the
existing state transition error log with the object information, and
add a debug log message on the success path.
|
See issue #3124. |
siddardh-ra
approved these changes
Dec 21, 2022
dbutenhof
approved these changes
Dec 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When handling exceptions, certain kinds of exceptions in either SQLAlchemy or in PyscoPG2 will cause references to the SQLAlchemy object instance to cause other exceptions. For example, one might see:
By moving the log messages after the
rollback()call, we avoid the extra mess caused.We also use the
self.loggerwhere possible, and we enhance the existing state transition error log with the object information, and add a debug log message on the success path.