Give Go module initialized with dispatch init the same name as it's directory name
#81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
achille-roussel
approved these changes
Jul 4, 2024
| return err | ||
| } | ||
|
|
||
| // TODO: create .gitignore file? |
There was a problem hiding this comment.
Could we add a .gitignore file to the template so we don't need this to be a special case?
There was a problem hiding this comment.
I initially added it, but we never know what will be the -o flag value to ignore the binary. I made it equal to the directory name as well initially (when -o is omitted), but that's also dynamical.
What known in advance Go directories and files I should exclude?
There was a problem hiding this comment.
What do you think about these two for Go and Python?
https://github.com/github/gitignore/blob/main/Go.gitignore
https://github.com/github/gitignore/blob/main/Python.gitignore
There was a problem hiding this comment.
Let's roll with these 👍
|
Merging this. See #82 for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This code patches the first line of the
go.modfile to set a module name to a directory name.