Avoid opaque byte fields/containers #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chicoxyzzy
approved these changes
Jun 11, 2024
See https://buf.build/docs/breaking/rules#field_same_oneof. The exception they mention applies to the current branch. Disable the rule temporarily so that we can get the change through.
achille-roussel
approved these changes
Jun 12, 2024
This was referenced Jun 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR deprecates the
bytes coroutine_statefield onPoll{,Result}in favor of agoogle.protobuf.Anyfield. The additional type URL will help systems introspecting the state; they would otherwise have to guess what the opaque bytes represent.This PR also adds a wrapper message for pickled Python values, so that the Python SDK can attach a type URL to Python inputs, outputs and now
state. Previously we were using the built-inBytesValuemessage, and so elsewhere had to guess what the opaque bytes represent.