Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add function_version to Call #32

Merged
merged 2 commits into from
May 24, 2024
Merged

Add function_version to Call #32

merged 2 commits into from
May 24, 2024

Conversation

Pryz
Copy link
Contributor

@Pryz Pryz commented May 24, 2024

This changes add a function_version field to the Call data model to allow selecting the right version of the code during execution.

Copy link
Contributor

@achille-roussel achille-roussel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess the only question would be whether this field is better named function_version or version, function/function_version is a bit redundant, but also very clear.

I don't have a strong opinion on the matter, just bringing it up in case it inspires a change.

@Pryz
Copy link
Contributor Author

Pryz commented May 24, 2024

Yes, I was considering just using version at first but might be better to be very clear here. Otherwise it could be a function version, endpoint version, input data model version, etc

Switching to version since it indicates the version of the code to be execution and not the version of a single function within that code.

@Pryz Pryz merged commit 40d559c into main May 24, 2024
3 checks passed
@Pryz Pryz deleted the function-version branch May 24, 2024 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants