Lenient numeric decoding #1606
Open
Lenient numeric decoding #1606
+260
−110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kubukoz
reviewed
Oct 4, 2024
Comment on lines
+81
to
+85
| /** | ||
| * Enables lenient decoding of numeric values, where numbers may be carried by JSON strings | ||
| * as well as JSON numbers. | ||
| */ | ||
| def withLenientNumericDecoding: JsoniterCodecCompiler |
There was a problem hiding this comment.
question: shall we just call it lenient decoding, in case we add more cases of leniency? such as, case-insensitivity (which might not be doable if there are members with names like foo and FOO, but might be possible in many cases)
There was a problem hiding this comment.
and we'd just mention number handling because it happens to be the only thing for now
There was a problem hiding this comment.
I'd rather have more granular options than a "one size fits all" option.
modules/json/test/src/smithy4s/json/SchemaVisitorJCodecCustomisationTests.scala
Show resolved
Hide resolved
Co-authored-by: Jakub Kozłowski <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds opt-in logic to allow decoding numeric values from JSON strings.
This also exposes a new method on the SimpleRestJsonBuilder to configure the underlying JSON codecs, without having to duplicate the smart-builder methods every time we add new options.
PR Checklist (not all items are relevant to all PRs)