Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove smithy4sRenderOptics setting from plugins #1566

Merged

Conversation

yisraelU
Copy link
Contributor

@yisraelU yisraelU commented Jul 5, 2024

and the corresponding sbt-test module
closes #1537

PR Checklist (not all items are relevant to all PRs)

  • Added documentation
  • Updated changelog

@kubukoz
Copy link
Member

kubukoz commented Jul 6, 2024

Do we still have tests that utilize the optics being generated conditionally?

@yisraelU
Copy link
Contributor Author

Do we still have tests that utilize the optics being generated conditionally?

I thought so , I will verify

@kubukoz
Copy link
Member

kubukoz commented Sep 28, 2024

Confirmed, we have:

  • tests in renderer that assert on the exact rendered code (btw it would be a nice usecase for https://github.com/siriusxm/snapshot4s), these ensure that we don't just generate optics for everything
  • tests that involve using actual generated optics on the types that got them, these ensure that the config isn't ignored

so I think we're good.

@@ -278,7 +272,6 @@ object Smithy4sCodegenPlugin extends AutoPlugin {
file,
s"""$$version: "2"
|metadata smithy4sWildcardArgument = "$wildcardArg"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thought: I would consider dropping smithy4sWildcardArgument too, we should use * and ask people to enable -Xsource:3 or -Xsource:3-cross.

@kubukoz kubukoz merged commit ebba231 into disneystreaming:series/0.19 Sep 28, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants