Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update README.md - Add metrics setup instructions for puma single mode #311

Merged
merged 1 commit into from
Apr 9, 2024
Merged

Update README.md - Add metrics setup instructions for puma single mode #311

merged 1 commit into from
Apr 9, 2024

Conversation

oozzal
Copy link
Contributor

@oozzal oozzal commented Mar 20, 2024

There are instructions for puma single mode in other sections of the Readme. It was missing for puma core metrics.

@benoittgt
Copy link

Isnt' something that should handled by the code itself?

@oozzal
Copy link
Contributor Author

oozzal commented Apr 4, 2024

@benoittgt existing readme instruction only works for Puma clustered mode and actually fails for Puma single mode.

@benoittgt
Copy link

Good point

@SamSaffron
Copy link
Member

thanks!

@SamSaffron SamSaffron merged commit 66c1f39 into discourse:main Apr 9, 2024
0 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SamSaffron SamSaffron SamSaffron approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@oozzal @benoittgt @SamSaffron