Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DEV: Remove hardcoded Ruby GC tweaks #60

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

DEV: Remove hardcoded Ruby GC tweaks #60

wants to merge 1 commit into from

Conversation

xfalcox
Copy link
Member

@xfalcox xfalcox commented Jan 19, 2023

No description provided.

@xfalcox xfalcox marked this pull request as ready for review January 19, 2023 18:00
@SamSaffron
Copy link
Member

Do we know which of the tweaks breaks Ruby? We need to report this to https://bugs.ruby-lang.org/ - can you make it so?

@xfalcox
Copy link
Member Author

xfalcox commented Jan 20, 2023

Do we know which of the tweaks breaks Ruby? We need to report this to https://bugs.ruby-lang.org/ - can you make it so?

While working on a minimal repro to fill the issue, found it was already reported at

https://bugs.ruby-lang.org/issues/19284

@davidtaylorhq
Copy link
Member

@xfalcox I guess this was resolved upstream? Good to close?

@xfalcox
Copy link
Member Author

xfalcox commented Apr 11, 2023

@xfalcox I guess this was resolved upstream? Good to close?

Upstream learned to ignore when the values are invalid. I would still lean on removing those if possible, but won't die on this hill

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidtaylorhq davidtaylorhq davidtaylorhq approved these changes

@SamSaffron SamSaffron Awaiting requested review from SamSaffron

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xfalcox @SamSaffron @davidtaylorhq