DEV: Switch to new API to render into plugin outlet #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgxworld
force-pushed
the
sample_use_new_api
branch
from
81b1e7d to
cd07118
Compare
tgxworld
changed the title
Why this change? The renderInOutlet plugin API was introduced in Discourse core which we will prefer to use going forward.
tgxworld
force-pushed
the
sample_use_new_api
branch
from
cd07118 to
757cc2e
Compare
|
Thank you again @martin-brennan 👍 |
tgxworld
added a commit
that referenced
this pull request
Oct 16, 2023
This partially reverts commit 8740486.
tgxworld
added a commit
that referenced
this pull request
Oct 16, 2023
This partially reverts commit 8740486. Compatibility issue is causing the theme to break: https://meta.discourse.org/t/-/282144
tgxworld
added a commit
that referenced
this pull request
Oct 16, 2023
This partially reverts commit 8740486. Compatibility issue is causing the theme to break: https://meta.discourse.org/t/-/282144
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this change?
The
renderInOutletplugin API was introduced in Discourse core whichwe will prefer to use going forward.