DEV: Migrate icons and links settings to new objects setting type #36
Conversation
tgxworld
force-pushed
the
migrate_settings
branch
3 times, most recently
from
596bd24 to
d3362ce
Compare
.discourse-compatibility
Outdated
| @@ -1,3 +1,4 @@ | |||
| < 3.3.0.beta2-dev: 0a837d7c044798417b1a7389cc37a67859c25dbe | |||
There was a problem hiding this comment.
Where did you get this SHA from?
There was a problem hiding this comment.
Ah good catch. I have no idea where that SHA came from but I have now updated the SHA to point to e64cfa5
Since discourse/discourse@a440e15, we have started to support objects typed theme setting so we are switching this theme component to use it instead as it provides a much better UX for configuring the settings required for the theme component.
tgxworld
force-pushed
the
migrate_settings
branch
from
d3362ce to
a1d775c
Compare
| @@ -1,3 +1,4 @@ | |||
| < 3.3.0.beta2-dev: e64cfa531121f2cf152901f5b2a20512a5ee2c63 | |||
| type: enum | ||
| default: _blank | ||
| choices: | ||
| - _blank |
There was a problem hiding this comment.
Btw, why the _? I notice it wasn't a thing in discourse/discourse-custom-header-links#53. Need some standardization?
There was a problem hiding this comment.
In discourse-custom-header-links it doesn't just use the target directly in the link's target attribute.
In the case of this plugin, the value of the property is used directly in the target attribute so we need to use the actual valid values
You cancelled the test run? |
|
Hmm nope, not sure what happened. I kicked off another rerun. |
|
Thank you for reviewing @nattsw 👍 |
Why this change?
Since discourse/discourse@a440e15, we have started to support objects typed theme setting so we are switching this theme component to use it instead as it provides a much better UX for configuring the settings required for the theme component.