types: bump @types/node version, use EventEmitter generic
#10584
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Qjuh
requested review from
SpaceEEC,
Jiralite,
ckohen,
monbrey and
almostSouji
iCrawl
approved these changes
Oct 31, 2024
almeidx
changed the title
@types/node version, use EventEmitter generic@types/node version, use EventEmitter generic
Renegade334
reviewed
Oct 31, 2024
There was a problem hiding this comment.
Suggest this should be semver:major, as it will cause new compile errors for downstream projects (in the absence of skipLibCheck) if their installed @types/node version dates from prior to EventEmitter taking a type parameter.
The @types/node patch that allowed for event-mapped returns from top-level node:events functions has had to be reverted, so whether to provide a typed solution for events.on() and events.once() probably still needs to be considered.
| @@ -949,7 +952,7 @@ export type If<Value extends boolean, TrueResult, FalseResult = null> = Value ex | |||
| ? FalseResult | |||
| : TrueResult | FalseResult; | |||
|
|
|||
| export class Client<Ready extends boolean = boolean> extends BaseClient { | |||
| export class Client<Ready extends boolean = boolean> extends BaseClient<ClientEvents> { | |||
There was a problem hiding this comment.
Is there a case for Client exposing its own type parameter here, for derived classes to be able to add their own mapped events?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes this PR makes and why it should be merged:
Bumps
@types/nodeto latest version for the respective node version used in each package but@discordjs/rest, because there's a clash on the types for globalfetch()function that needs to be resolved.Adapts mainlib
discord.jstypings to use the EventEmitter generic instead of manual overloads for EventEmitter methods.Supersedes #10581.
Status and versioning classification: