Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Application hosted Emoji support #2726

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

yoyosource
Copy link

Pull Request Etiquette

Changes

  • Internal code
  • Library interface (affecting end-user code)
  • Documentation
  • Other: _____

Closes Issue: NaN

Description

Supersedes #2712 with a cleaned up commit list and implementation of freya022's change requests.

Implements this api-docs PR: discord/discord-api-docs#7010.

@yoyosource yoyosource mentioned this pull request Sep 4, 2024
6 tasks
@yoyosource yoyosource changed the title Feature/application emojis Application hosted Emoji support Sep 4, 2024
@yoyosource
Copy link
Author

I tested this code in production for around 2 weeks now. It works fine for me.

*/
@Nonnull
@CheckReturnValue
RestAction<ApplicationEmoji> createApplicationEmoji(@Nonnull String name, @Nonnull Icon icon);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is missing documentation for the return type and exceptions

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So actually I only see this warning (https://github.com/discord/discord-api-docs/blob/main/docs/resources/Emoji.md#create-application-emoji--post-applicationsapplicationiddocs_resources_applicationapplication-objectemojis) in the docs. With a 400 Bad Request for file sizes greater then 256KiB. How exactly should I write that down?

src/main/java/net/dv8tion/jda/api/JDA.java Outdated Show resolved Hide resolved
src/main/java/net/dv8tion/jda/api/JDA.java Outdated Show resolved Hide resolved
src/main/java/net/dv8tion/jda/api/JDA.java Show resolved Hide resolved
@yoyosource
Copy link
Author

yoyosource commented Oct 7, 2024

I actually dont know why the online (github.dev) editor creates such big diffs. I am trying to fix those.

@MinnDevelopment
Copy link
Member

I actually dont know why the online (github.dev) creates such big diffs. I am trying to fix those.

You are likely changing line endings, when you use git directly it will make sure to convert them to the correct line endings when committing files.

@yoyosource
Copy link
Author

I actually dont know why the online (github.dev) creates such big diffs. I am trying to fix those.

You are likely changing line endings, when you use git directly it will make sure to convert them to the correct line endings when committing files.

It is fixed now. I never changed it intentionally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants