-
-
Notifications
You must be signed in to change notification settings - Fork 735
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Application hosted Emoji support #2726
base: master
Are you sure you want to change the base?
Application hosted Emoji support #2726
Conversation
I tested this code in production for around 2 weeks now. It works fine for me. |
*/ | ||
@Nonnull | ||
@CheckReturnValue | ||
RestAction<ApplicationEmoji> createApplicationEmoji(@Nonnull String name, @Nonnull Icon icon); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is missing documentation for the return type and exceptions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So actually I only see this warning (https://github.com/discord/discord-api-docs/blob/main/docs/resources/Emoji.md#create-application-emoji--post-applicationsapplicationiddocs_resources_applicationapplication-objectemojis) in the docs. With a 400 Bad Request for file sizes greater then 256KiB. How exactly should I write that down?
src/main/java/net/dv8tion/jda/api/entities/emoji/ApplicationEmoji.java
Outdated
Show resolved
Hide resolved
src/main/java/net/dv8tion/jda/internal/entities/EntityBuilder.java
Outdated
Show resolved
Hide resolved
src/main/java/net/dv8tion/jda/internal/entities/emoji/ApplicationEmojiImpl.java
Outdated
Show resolved
Hide resolved
src/main/java/net/dv8tion/jda/internal/entities/emoji/ApplicationEmojiImpl.java
Outdated
Show resolved
Hide resolved
src/main/java/net/dv8tion/jda/internal/entities/emoji/ApplicationEmojiImpl.java
Outdated
Show resolved
Hide resolved
src/main/java/net/dv8tion/jda/internal/entities/EntityBuilder.java
Outdated
Show resolved
Hide resolved
src/main/java/net/dv8tion/jda/internal/entities/emoji/ApplicationEmojiImpl.java
Outdated
Show resolved
Hide resolved
src/main/java/net/dv8tion/jda/internal/managers/ApplicationEmojiManagerImpl.java
Outdated
Show resolved
Hide resolved
eecd1c0
to
4521244
Compare
I actually dont know why the online (github.dev) editor creates such big diffs. I am trying to fix those. |
You are likely changing line endings, when you use git directly it will make sure to convert them to the correct line endings when committing files. |
4521244
to
9d48ce5
Compare
It is fixed now. I never changed it intentionally. |
Pull Request Etiquette
Changes
Closes Issue: NaN
Description
Supersedes #2712 with a cleaned up commit list and implementation of freya022's change requests.
Implements this api-docs PR: discord/discord-api-docs#7010.