Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add settings handling #58

Merged
merged 9 commits into from
Jun 2, 2024
Merged

add settings handling #58

merged 9 commits into from
Jun 2, 2024

Conversation

disberd
Copy link
Owner

@disberd disberd commented Jun 2, 2024

This PR cleans up some previous mistakes in implementation, making extension handling hopefully more robust.
It closes #57.

It also adds a new functionality to parse custom settings for modifying the macro behavior.
Similarly to @skiplines, these are parsed from the input expression provided.

For the time being, only the setting SHOULD_PREPEND_LOAD_PATH is supported

Copy link

codecov bot commented Jun 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (108ee6d) to head (7cb1096).

Additional details and impacted files
@@            Coverage Diff            @@
##            master       #58   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           11        12    +1     
  Lines          771       840   +69     
=========================================
+ Hits           771       840   +69     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@disberd disberd merged commit a2775e5 into master Jun 2, 2024
9 checks passed
@disberd disberd deleted the fix_project_copy branch June 2, 2024 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

copied project in update_active_from_target! misses extensions
1 participant