Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup notebook deps #53

Merged
merged 5 commits into from
May 29, 2024
Merged

Cleanup notebook deps #53

merged 5 commits into from
May 29, 2024

Conversation

disberd
Copy link
Owner

@disberd disberd commented May 27, 2024

this just does some cleanup of the codebase, removes all remaining included notebooks, allowing to remove Markdown, InteractiveUtils and Random as dependencies.

MacroTools is still a dependency because we rely on shortdef for the @addmethod macro.

Some tests were also added to reach 100% coverage (though the last added tests for getting to the paths of @macroexpand and multiple call error from different cells was quite weird, might consider revisiting the underlying functionality)

Copy link

codecov bot commented May 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (8b6a000) to head (fe5ec45).

Additional details and impacted files
@@             Coverage Diff             @@
##           master       #53      +/-   ##
===========================================
+ Coverage   99.50%   100.00%   +0.49%     
===========================================
  Files          11        11              
  Lines         813       813              
===========================================
+ Hits          809       813       +4     
+ Misses          4         0       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@disberd disberd merged commit 793507b into master May 29, 2024
9 checks passed
@disberd disberd deleted the remove_plutoinclude branch May 29, 2024 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant