Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove PlutoCombineHTL module and corresponding dependencies #52

Merged
merged 7 commits into from
May 26, 2024

Conversation

disberd
Copy link
Owner

@disberd disberd commented May 26, 2024

This PR removes the PlutoCombineHTL submodule from PlutoDevMacros.

This now lives in its own repository though it's not registered.

This removal reduces the codebase and removes some dependencies in an effort to make PlutoDevMacros depends on as few packages as possible.

Some dependencies (i.e. MacroTools, Random, InteractiveUtils and Markdown) are still there due to a lingering presence of the notebook defining the @plutoinclude macro which will be removed in a next PR

Copy link

codecov bot commented May 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.50%. Comparing base (03eec7c) to head (5c21dcb).

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #52      +/-   ##
==========================================
+ Coverage   99.43%   99.50%   +0.07%     
==========================================
  Files          16       11       -5     
  Lines        1234      813     -421     
==========================================
- Hits         1227      809     -418     
+ Misses          7        4       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@disberd
Copy link
Owner Author

disberd commented May 26, 2024

Here is the gif for the hide_this_log function

d31ed74f-5a60-44e1-8080-84824ba9d878

@disberd disberd merged commit 01062ea into master May 26, 2024
9 checks passed
@disberd disberd deleted the excise_combine_htl branch May 26, 2024 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant