Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable re-exporting names from using statements in catch-all expressions #48

Merged
merged 9 commits into from
May 25, 2024

Conversation

disberd
Copy link
Owner

@disberd disberd commented May 25, 2024

This PR adds an opt-in way of re-import all names defined via using statements when using catch-all import expression in @fromparent or @frompackage.

To do so, just prepend the catch-all importstatement with the @include_using macro, as shown in the following example:

@fromparent @include_using import *

This macro is not actually defined in the package and only processed during macro expansion of @frompackage/@fromparent.

This is currently an opt-in to avoid a breaking change, but it will likely became the default (with an opt-out) in the next breaking release.

Fixes #11

Copy link

codecov bot commented May 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.40%. Comparing base (c937d20) to head (e9340d9).

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #48      +/-   ##
==========================================
+ Coverage   99.37%   99.40%   +0.02%     
==========================================
  Files          16       16              
  Lines        1120     1172      +52     
==========================================
+ Hits         1113     1165      +52     
  Misses          7        7              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@disberd disberd merged commit 9f69c9f into master May 25, 2024
9 checks passed
@disberd disberd deleted the track_usings_names branch May 25, 2024 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

variables imported via using in previous notebooks are not visible
1 participant