PlutoCombineHTL Submodule [BREAKING] #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified lines are covered by tests ✅
📢 Thoughts on this report? Let us know!. |
Default to always show scripts as non-modules to simplify currentScript
disberd
changed the title
disberd
changed the title
Added some convenience methods to formatted_code
Now CombinedScripts only accepts a vector of PrintToScript and CombineNodes only accepts a vector of ShowWithPrintHTML
…nd ShowWithPrintHTML
It reverts to print_script from HypertextLiteral outside Pluto and published_to_js inside pluto
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ditches the Script submodule for the PlutoCombineHTL submodule which implements the functionality of providing convenience methods to show and combine scripts and HTML nodes both in Pluto and outside Pluto
This has now a much broader scope of what the Script module provided.
For the time being no documentation or docstrings are present as it's still a work in progress.
I am anyhow merging to tag a new breaking release in order to start experimenting with this.