Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate from notebooks #22

Merged
merged 8 commits into from
Aug 30, 2023
Merged

Migrate from notebooks #22

merged 8 commits into from
Aug 30, 2023

Conversation

disberd
Copy link
Owner

@disberd disberd commented Aug 30, 2023

This PR migrates the rest of PlutoDevMacros from notebook to actual julia files

It also introduces a fix for a breaking of HypertextLiteral.print_script on 1.10 (See HTL's Issue 33)

This PR will not migrate the following notebooks:

  • notebooks/plutoinclude_macro.jl
  • notebooks/mapexpr.jl

As they will be removed soon for the next breaking release

@codecov
Copy link

codecov bot commented Aug 30, 2023

Codecov Report

Patch coverage is 98.38% of modified lines.

Files Changed Coverage
src/PlutoDevMacros.jl ø
src/script/Script.jl 98.13%
src/basics.jl 100.00%
src/frompackage/helpers.jl 100.00%
src/html_helpers.jl 100.00%

📢 Thoughts on this report? Let us know!.

@disberd disberd merged commit c68d666 into master Aug 30, 2023
@disberd disberd deleted the migrate_from_notebooks branch August 30, 2023 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant